GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(router): Ensure `APP_INITIALIZER` of `enabledBlocking` option com… by atscott · Pull Request #46634 · angular/angular

Conversation

@atscott

@atscott atscott commented Jun 29, 2022

Copy link
Copy Markdown
Contributor

Patch target for #46026

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@atscott
fix(router): Ensure APP_INITIALIZER of enabledBlocking option com…
b3ba63c
…pletes

Previously, if `initialNavigation` were set to `enabledBlocking`, the
Router's `APP_INITIALIZER` would never resolve if that initial
navigation failed. This results in the application load hanging and
never completing.

fixes angular#44355
@atscott atscott added area: router target: patch This PR is targeted for the next patch release labels Jun 29, 2022
@ngbot ngbot Bot added this to the Backlog milestone Jun 29, 2022
@atscott
atscott requested a review from alxhub June 29, 2022 22:12
@alxhub alxhub added the PullApprove: disable label Jun 29, 2022
alxhub
alxhub approved these changes Jun 29, 2022
View reviewed changes
@atscott atscott added the action: merge The PR is ready for merge by the caretaker label Jun 29, 2022
@atscott

atscott commented Jun 29, 2022

Copy link
Copy Markdown
Contributor Author

This PR was merged into the repository by commit a3bd65e.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@atscott atscott closed this Jun 29, 2022
atscott added a commit that referenced this pull request Jun 29, 2022
@atscott
fix(router): Ensure APP_INITIALIZER of enabledBlocking option com…
a3bd65e
…pletes (#46634)

Previously, if `initialNavigation` were set to `enabledBlocking`, the
Router's `APP_INITIALIZER` would never resolve if that initial
navigation failed. This results in the application load hanging and
never completing.

fixes #44355

PR Close #46634
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Jul 11, 2022
Calciumdibromid Bot cabr2-bot Epsilon_02
Update angular monorepo to v14.0.5 (#1451)
f7c7def
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@angular/animations](https://github.com/angular/angular) | dependencies | patch | [`14.0.4` -> `14.0.5`](https://renovatebot.com/diffs/npm/@angular%2fanimations/14.0.4/14.0.5) |
| [@angular/common](https://github.com/angular/angular) | dependencies | patch | [`14.0.4` -> `14.0.5`](https://renovatebot.com/diffs/npm/@angular%2fcommon/14.0.4/14.0.5) |
| [@angular/compiler](https://github.com/angular/angular) | dependencies | patch | [`14.0.4` -> `14.0.5`](https://renovatebot.com/diffs/npm/@angular%2fcompiler/14.0.4/14.0.5) |
| [@angular/compiler-cli](https://github.com/angular/angular) | devDependencies | patch | [`14.0.4` -> `14.0.5`](https://renovatebot.com/diffs/npm/@angular%2fcompiler-cli/14.0.4/14.0.5) |
| [@angular/core](https://github.com/angular/angular) | dependencies | patch | [`14.0.4` -> `14.0.5`](https://renovatebot.com/diffs/npm/@angular%2fcore/14.0.4/14.0.5) |
| [@angular/forms](https://github.com/angular/angular) | dependencies | patch | [`14.0.4` -> `14.0.5`](https://renovatebot.com/diffs/npm/@angular%2fforms/14.0.4/14.0.5) |
| [@angular/platform-browser](https://github.com/angular/angular) | dependencies | patch | [`14.0.4` -> `14.0.5`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser/14.0.4/14.0.5) |
| [@angular/platform-browser-dynamic](https://github.com/angular/angular) | dependencies | patch | [`14.0.4` -> `14.0.5`](https://renovatebot.com/diffs/npm/@angular%2fplatform-browser-dynamic/14.0.4/14.0.5) |

---

### Release Notes

<details>
<summary>angular/angular</summary>

### [`v14.0.5`](https://github.com/angular/angular/blob/HEAD/CHANGELOG.md#&#8203;1405-2022-07-06)

[Compare Source](angular/angular@14.0.4...14.0.5)

##### router

| Commit | Type | Description |
| -- | -- | -- |
| [a3bd65e2b8](angular/angular@a3bd65e) | fix | Ensure `APP_INITIALIZER` of `enabledBlocking` option completes ([#&#8203;46634](angular/angular#46634)) |

#### Special Thanks

Alan Agius, Alex Rickabaugh, Andrew Kushnir, Andrew Scott, Aristeidis Bampakos, Bob Watson, George Kalpakas, Paul Gschwendtner and Pawel Kozlowski

<!-- CHANGELOG SPLIT MARKER -->

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

Co-authored-by: cabr2-bot <[email protected]>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1451
Reviewed-by: Epsilon_02 <[email protected]>
Co-authored-by: Calciumdibromid Bot <[email protected]>
Co-committed-by: Calciumdibromid Bot <[email protected]>
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Jul 30, 2022

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Jul 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alxhub alxhub alxhub approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: router PullApprove: disable target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@atscott @alxhub
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.