GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — feat(zone.js): Update to the simpler Async Stack Tagging v2 API by victorporof · Pull Request #46958 · angular/angular

Conversation

victorporof commented Jul 25, 2022

Copy link

Copy Markdown

Contributor

Signed-off-by: Victor Porof [email protected]

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/main/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Bugfix
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Documentation content changes
angular.io application / infrastructure changes
Other... Please describe:

Chrome DevTools is planning on dropping the experimental flag for the new async stack tagging API and enabling this feature by default on the console object. As part of this, the API has been improved to be more robust. More details in the chromium bug and in the V8 implementation.

Does this PR introduce a breaking change?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

tonivj5 and LanderBeeuwsaert reacted with heart emoji

All reactions

❤️ 2 reactions

pullapprove Bot requested a review from JiaLiPassion

July 25, 2022 09:08

victorporof commented Jul 25, 2022

Copy link

Copy Markdown

Contributor Author

@JiaLiPassion @mgechev PTAL!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JiaLiPassion reviewed

Jul 25, 2022

View reviewed changes

Comment thread

packages/zone.js/lib/zone-spec/async-stack-tagging.ts Outdated

JiaLiPassion Jul 25, 2022

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the previous version, scheduleAsyncTask has the 2nd parameter which tells console the task is period or not,

if it is not period task, then finishAsyncTask can only be called once.
if it is period task such as eventTask or setInterval, finishAsyncTask can be called multiple times.

So in the v2 API, this spec has been changed?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

victorporof Jul 26, 2022

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, in the new API, tasks can always be recurring (aka, they can run multiple times). Consumers of the API don't need to specify this beforehand, nor do they need to cancel the tasks anymore. More details here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JiaLiPassion reacted with thumbs up emoji

All reactions

👍 1 reaction

mgechev approved these changes

Jul 25, 2022

View reviewed changes

jessicajaniuk added the area: zones Issues related to zone.js label

Jul 25, 2022

ngbot Bot added this to the Backlog milestone

Jul 25, 2022


          feat(zone.js): Update to the simpler Async Stack Tagging v2 API

da9d273

Signed-off-by: Victor Porof <[email protected]>

victorporof force-pushed the astv2 branch from a210857 to da9d273 Compare

July 26, 2022 09:09

angular-robot Bot requested a review from mgechev

July 26, 2022 09:10

victorporof commented Jul 26, 2022

Copy link

Copy Markdown

Contributor Author

Last minute change: we renamed console.scheduleTask to console.createTask. Updated the PR to reflect that.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JiaLiPassion approved these changes

Jul 26, 2022

View reviewed changes

JiaLiPassion commented Jul 26, 2022

Copy link

Copy Markdown

Contributor

@victorporof , thank you for the explaination, LGTM.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JiaLiPassion added action: merge

The PR is ready for merge by the caretaker

target: minor This PR is targeted for the next minor release labels

Jul 26, 2022

AndrewKushnir added the action: global presubmit The PR is in need of a google3 global presubmit label

Aug 1, 2022

AndrewKushnir commented Aug 1, 2022

Copy link

Copy Markdown

Contributor

@victorporof could you please run a TGP with those changes to make sure there are no failures in g3? Thank you.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

victorporof commented Aug 3, 2022

Copy link

Copy Markdown

Contributor Author

@AndrewKushnir I'm not sure what that means :) What button should I press and where can I find it? 😄

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

victorporof mentioned this pull request

Aug 3, 2022

feat: Add Async Stack Tagging API support #46693

Closed

2 of 12 tasks

AndrewKushnir commented Aug 3, 2022

Copy link

Copy Markdown

Contributor

@victorporof no worries, I'll take care of it and let you know if there are any failures.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AndrewKushnir self-assigned this

Aug 3, 2022

AndrewKushnir commented Aug 4, 2022

Copy link

Copy Markdown

Contributor

Global Presubmit.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

victorporof commented Aug 4, 2022

Copy link

Copy Markdown

Contributor Author

Global Presubmit.

Thank you @AndrewKushnir! I see a few failures there, are they related to this PR?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AndrewKushnir removed the action: global presubmit The PR is in need of a google3 global presubmit label

Aug 4, 2022

AndrewKushnir commented Aug 4, 2022

Copy link

Copy Markdown

Contributor

@victorporof test failures turned out to be flakes, so this PR is now ready for merge. Thank you.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AndrewKushnir added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label

Aug 4, 2022

AndrewKushnir commented Aug 4, 2022

Copy link

Copy Markdown

Contributor

Merge-assistance: LGTM from Jia should be enough to proceed with this change. TGP is "green".

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

dylhunn commented Aug 4, 2022

Copy link

Copy Markdown

Contributor

This PR was merged into the repository by commit f23232f.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

dylhunn closed this in

f23232f

Aug 4, 2022

crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request

Aug 23, 2022


          Update dependency zone.js to v0.11.8 (#1504)

468f892

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [zone.js](https://github.com/angular/angular) ([changelog](https://github.com/angular/angular/blob/master/packages/zone.js/CHANGELOG.md)) | dependencies | patch | [`0.11.7` -> `0.11.8`](https://renovatebot.com/diffs/npm/zone.js/0.11.7/0.11.8) |

---

### Release Notes

<details>
<summary>angular/angular</summary>

### [`v0.11.8`](https://github.com/angular/angular/blob/HEAD/packages/zone.js/CHANGELOG.md#&#8203;0118-httpsgithubcomangularangularcomparezonejs-0117zonejs-0118-2022-08-08)

[Compare Source](angular/angular@zone.js-0.11.7...zone.js-0.11.8)

##### Features

-   **zone.js:** Update to the simpler Async Stack Tagging v2 API ([#&#8203;46958](angular/angular#46958)) ([f23232f](angular/angular@f23232f))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNTYuMCIsInVwZGF0ZWRJblZlciI6IjMyLjE1OS4xIn0=-->

Co-authored-by: cabr2-bot <[email protected]>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1504
Reviewed-by: Epsilon_02 <[email protected]>
Co-authored-by: Calciumdibromid Bot <[email protected]>
Co-committed-by: Calciumdibromid Bot <[email protected]>

sync-by-unito Bot mentioned this pull request

Sep 1, 2022

build(deps): bump zone.js from 0.11.4 to 0.11.8 numbersprotocol/capture-cam#2003

Closed

angular-automatic-lock-bot Bot commented Sep 4, 2022

Copy link

Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

angular-automatic-lock-bot Bot locked and limited conversation to collaborators

Sep 4, 2022

Reviewers

mgechev

Awaiting requested review from mgechev

1 more reviewer

JiaLiPassion

JiaLiPassion approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

AndrewKushnir

Labels

action: merge

The PR is ready for merge by the caretaker

area: zones

Issues related to zone.js

merge: caretaker note

Alert the caretaker performing the merge to check the PR for an out of normal action needed or note

target: minor

This PR is targeted for the next minor release

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.