GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — feat(@angular-devkit/build-angular): fine grain settings for sourceMaps by alan-agius4 · Pull Request #13062 · angular/angular-cli

Conversation

alan-agius4 commented Nov 27, 2018 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Collaborator

This PR add more control over which sourceMaps you want, Now you can enable sourceMaps for scripts only, styles only or both. Also we added another functionality which are hidden sourcemaps. These are normally used for error reporting tools.

Fixes #7527

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

alan-agius4 added the target: patch This PR is targeted for the next patch release label

Nov 27, 2018

alan-agius4 requested a review from filipesilva

November 27, 2018 12:55

googlebot added the cla: yes label

Nov 27, 2018

alan-agius4 removed the target: patch This PR is targeted for the next patch release label

Nov 27, 2018

alan-agius4 removed the request for review from filipesilva

November 27, 2018 12:56

alan-agius4 added the state: WIP label

Nov 27, 2018

alan-agius4 commented Nov 27, 2018

Copy link

Copy Markdown

Collaborator Author

Still need to add a couple of tests but this is the idea. @clydin, @hansl, @filipesilva

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

alan-agius4 requested review from clydin, filipesilva and hansl and removed request for clydin and hansl

November 27, 2018 14:17

clydin reviewed

Nov 27, 2018

View reviewed changes

Comment thread

packages/angular_devkit/build_angular/src/angular-cli-files/models/build-options.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

hansl reviewed

Nov 27, 2018

View reviewed changes

Comment thread

packages/angular_devkit/build_angular/src/angular-cli-files/models/build-options.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

alan-agius4 removed the state: WIP label

Nov 28, 2018

filipesilva approved these changes

Nov 29, 2018

View reviewed changes

filipesilva left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall. Really nice work and test coverage.

Historically, any change we make to sourcemaps breaks something though. It's just very hard to test the correctness of sourcemaps. After this comes in we should be especially aware on the issue tracker.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

packages/angular_devkit/build_angular/src/angular-cli-files/models/webpack-configs/utils.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

packages/angular/cli/lib/config/schema.json Outdated

		},
		"sourceMap": {
		"type": "boolean",
		"type": [

filipesilva Nov 29, 2018

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Schema bookkeeping is getting pretty annoying. We should find a way around this sometime.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

alan-agius4 reacted with thumbs up emoji

All reactions

👍 1 reaction

alan-agius4 Nov 29, 2018

Copy link

Copy Markdown

Collaborator Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it’s pretty hard even just to add a new property. You have to add t in multiple places

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

clydin reviewed

Nov 29, 2018

View reviewed changes

Comment thread

packages/angular_devkit/build_angular/src/angular-cli-files/models/webpack-configs/utils.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.

clydin reviewed

Nov 29, 2018

View reviewed changes

Comment thread

packages/angular_devkit/build_angular/src/browser/schema.json Resolved

Uh oh!

There was an error while loading. Please reload this page.

clydin reviewed

Nov 29, 2018

View reviewed changes

Comment thread

packages/angular_devkit/build_angular/src/karma/schema.json Resolved

Uh oh!

There was an error while loading. Please reload this page.

clydin reviewed

Nov 29, 2018

View reviewed changes

Comment thread

packages/angular_devkit/build_angular/src/karma/schema.json Resolved

Uh oh!

There was an error while loading. Please reload this page.


          feat(@angular/cli): update schema to match new sourceMap

a927603

ngbot Bot commented Nov 30, 2018 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

	Artifact	Baseline	Current	Change
❕	cli/new-production/test-project/main.js	173.60KB	174.25KB	+661 bytes

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          feat(@angular-devkit/build-angular): fine grain settings for sourceMaps

d64f2fe

This PR add more control over which sourceMaps you want, Now you can enable sourceMaps for scripts only, styles only or both. Also we added another functionality which are hidden sourcemaps. These are normaly used for error reporting tools.

Fixes #7527

angular deleted a comment from ngbot Bot

Nov 30, 2018

alan-agius4 added the target: major This PR is targeted for the next major release label

Nov 30, 2018

vikerman merged commit 8516d68 into angular:master

Nov 30, 2018

alan-agius4 deleted the fine_grain_sourcemaps branch

December 1, 2018 06:36

alan-agius4 mentioned this pull request

Dec 4, 2018

Feature request to generate sourcemaps for external services #12375

Closed

alan-agius4 mentioned this pull request

Jan 23, 2019

Ability to configure output path for source maps #13508

Closed

This was referenced Jan 30, 2019

Karma hangs with jsdom badeball/karma-jsdom-launcher#27

Open

Inability to avoid including source-map-support in Karma tests #13580

Closed

filipesilva added a commit to filipesilva/angular-cli that referenced this pull request

Feb 2, 2019


          fix(@angular-devkit/build-angular): use sourcemap object in karma plugin

e362d7a

Followup to angular#13062

Fix angular#13580

filipesilva mentioned this pull request

Feb 2, 2019

fix(@angular-devkit/build-angular): use sourcemap object in karma plugin #13584

Merged

vikerman pushed a commit that referenced this pull request

Feb 6, 2019


          fix(@angular-devkit/build-angular): use sourcemap object in karma plu…

e6f96fb

…gin (#13584)

Followup to #13062

Fix #13580

vikerman pushed a commit that referenced this pull request

Feb 6, 2019


          fix(@angular-devkit/build-angular): use sourcemap object in karma plu…

acc31ba

…gin (#13584)

Followup to #13062

Fix #13580

angular-automatic-lock-bot Bot commented Sep 12, 2019

Copy link

Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

angular-automatic-lock-bot Bot locked and limited conversation to collaborators

Sep 12, 2019

Reviewers

clydin

clydin left review comments

+2 more reviewers

hansl

hansl left review comments

filipesilva

filipesilva approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

target: major

This PR is targeted for the next major release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add option for hidden-source-map to use with ng build --prod

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

alan-agius4 commented Nov 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alan-agius4 commented Nov 27, 2018

Uh oh!

Uh oh!

Uh oh!

filipesilva left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

filipesilva Nov 29, 2018

Choose a reason for hiding this comment

Uh oh!

alan-agius4 Nov 29, 2018

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ngbot Bot commented Nov 30, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

angular-automatic-lock-bot Bot commented Sep 12, 2019

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

alan-agius4 commented Nov 27, 2018 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

ngbot Bot commented Nov 30, 2018 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.