GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(@schematics/angular): warn when target references a missing tsconfig by alan-agius4 · Pull Request #16063 · angular/angular-cli

Conversation

@alan-agius4

@alan-agius4 alan-agius4 commented Nov 5, 2019

Copy link
Copy Markdown
Collaborator

Fixes #16019

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@alan-agius4
fix(@schematics/angular): warn when target references a missing tsconfig
beea705
Fixes #16019
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Nov 5, 2019
@alan-agius4
alan-agius4 requested a review from filipesilva November 5, 2019 07:54
@googlebot googlebot added the cla: yes label Nov 5, 2019
filipesilva
filipesilva approved these changes Nov 5, 2019
View reviewed changes
@vikerman
vikerman merged commit 9ba7805 into angular:master Nov 6, 2019
@alan-agius4
alan-agius4 deleted the warn-on-missing-tsconfig branch November 6, 2019 05:15
@alan-agius4 alan-agius4 mentioned this pull request Nov 9, 2019
fix(@schematics/angular): return undefined instead of throw when file… #16134
Merged
mgechev pushed a commit that referenced this pull request Nov 11, 2019
@alan-agius4 @mgechev
fix(@schematics/angular): return undefined instead of throw when file…
1db57d4
… is not found

Follow up on #16063
mgechev pushed a commit that referenced this pull request Nov 11, 2019
@alan-agius4 @mgechev
fix(@schematics/angular): return undefined instead of throw when file…
88d4f09
… is not found

Follow up on #16063
@angular-automatic-lock-bot

angular-automatic-lock-bot Bot commented Dec 7, 2019

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Dec 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@filipesilva filipesilva filipesilva approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing tsconfig break update process

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@alan-agius4 @filipesilva @vikerman @googlebot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.