GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — chore(scripts/publish): get dist-tag from package.json by petebacondarwin · Pull Request #12722 · angular/angular.js

This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Conversation

@petebacondarwin

@petebacondarwin petebacondarwin commented Aug 31, 2015

Copy link
Copy Markdown
Contributor

This change would need to be cherry-picked to the previous version branches (with suitable change to package.json) to prevent releases from them breaking npm dist-tags.

Where does this need to be documented? New big version release tasks? Contributor documentation?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@petebacondarwin
chore(scripts/publish): get dist-tag from package.json
10cc6de
@googlebot googlebot added the cla: yes label Aug 31, 2015
@petebacondarwin

petebacondarwin commented Sep 1, 2015

Copy link
Copy Markdown
Contributor Author

The branch to dist-tag mapping will be as follows (once we fork and start working on 1.5.0):

  • 1.2.x -> ie8_compat
  • 1.3.x -> previous_1_3
  • 1.4.x -> latest
  • master -> beta
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Narretz

Narretz commented Sep 1, 2015

Copy link
Copy Markdown
Contributor

I think it's okay, although it's a bit cumbersome to update the branches.
Do we have access to our git in this step? Then we could check if there's a larger version number, and not set it in this case.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Narretz Narretz added the type: chore label Sep 1, 2015
@Narretz Narretz added this to the 1.4.6 milestone Sep 1, 2015
@petebacondarwin

petebacondarwin commented Sep 1, 2015

Copy link
Copy Markdown
Contributor Author

Going forward it will be quite straightforward. You only ever have to change the branch that is going from latest to previous... and then master swaps between latest and beta. We need to specify some dist-tag when publishing or it defaults to latest
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@IgorMinar

IgorMinar commented Sep 14, 2015

Copy link
Copy Markdown
Contributor

nice! lgtm
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@petebacondarwin petebacondarwin closed this in 30aa3ef Sep 14, 2015
petebacondarwin added a commit that referenced this pull request Sep 14, 2015
@petebacondarwin
chore(scripts/publish): get dist-tag from package.json
40e9bcd 
Closes #12722
petebacondarwin added a commit that referenced this pull request Sep 14, 2015
@petebacondarwin
chore(scripts/publish): get dist-tag from package.json
b94a47b 
Closes #12722
@petebacondarwin
petebacondarwin deleted the dist-tags branch November 24, 2016 09:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

cla: yes type: chore

Projects

None yet

Milestone

1.4.6

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@petebacondarwin @Narretz @IgorMinar @googlebot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.