GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — add eslint by robertIsaac · Pull Request #3421 · angular/angularfire

Conversation

robertIsaac commented Aug 29, 2023

Copy link

Copy Markdown

Contributor

Checklist

Issue number for this PR: NA
Docs included?: no
Test units included?: no
In a clean directory, yarn install, yarn test run successfully? no

Description

adding initial eslint and fixing the current errors

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

eieioxyz and LanderBeeuwsaert reacted with thumbs up emoji

All reactions

👍 2 reactions

robertIsaac force-pushed the add-eslint branch 2 times, most recently from 73e57ad to 4e28c06 Compare

August 29, 2023 09:35

robertIsaac added 2 commits

August 29, 2023 12:53


          add eslint

ca4665b


          cleanup build.ts

1cb5412

robertIsaac force-pushed the add-eslint branch from 4e28c06 to 1cb5412 Compare

August 29, 2023 09:53

davideast self-requested a review

August 29, 2023 16:25

davideast approved these changes

Aug 29, 2023

View reviewed changes

davideast left a comment

Copy link

Copy Markdown

Collaborator

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robertIsaac I can not thank you enough for this!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

robertIsaac reacted with heart emoji

All reactions

❤️ 1 reaction

davideast merged commit 4172abd into angular:master

Aug 29, 2023

robertIsaac commented Aug 29, 2023

Copy link

Copy Markdown

Contributor Author

@robertIsaac I can not thank you enough for this!

I'm really happy to see it merged :)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

robertIsaac commented Aug 29, 2023

Copy link

Copy Markdown

Contributor Author

@davideast I can also add prettier and eslint prettier plugin, if that's something you'd like to have in the project

jits and LanderBeeuwsaert reacted with thumbs up emoji

All reactions

👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

armando-navarro mentioned this pull request

Oct 8, 2026

fix(storage): give the compat fromTask an explicit return type #3796

Merged

armando-navarro added a commit that referenced this pull request

Oct 9, 2026


          fix(storage): give the compat fromTask an explicit return type (#3796)

4c5ba7e

fromTask declared no return type, so the published typings import
whatever path the typings bundler picks for the inferred firebase
type. In 20.x that is 'firebase/compat', which firebase's exports map
does not list. Apps using moduleResolution "bundler", the setting the
@angular/build migration moves apps to, fail with TS2307 in
@angular/fire/compat/storage. 21.0.0-rc.1 happens to emit
'firebase/compat/app' and compiles, but ng-packagr 22.2's new typings
bundler cannot parse the inferred type and fails the library build.

Declaring Observable<UploadTaskSnapshot> removes the inferred import.
The type is unchanged: UploadTaskSnapshot is the compat alias for
firebase.storage.UploadTaskSnapshot.

Also drop a comment explaining a firebase import that #3421 removed
in 2023 as unused. The import only existed to steer these typings.

Fixes #3677

armando-navarro added a commit that referenced this pull request

Oct 10, 2026


          fix(storage): give the compat fromTask an explicit return type (#3796)

263f381

fromTask declared no return type, so the published typings import
whatever path the typings bundler picks for the inferred firebase
type. In 20.x that is 'firebase/compat', which firebase's exports map
does not list. Apps using moduleResolution "bundler", the setting the
@angular/build migration moves apps to, fail with TS2307 in
@angular/fire/compat/storage. 21.0.0-rc.1 happens to emit
'firebase/compat/app' and compiles, but ng-packagr 22.2's new typings
bundler cannot parse the inferred type and fails the library build.

Declaring Observable<UploadTaskSnapshot> removes the inferred import.
The type is unchanged: UploadTaskSnapshot is the compat alias for
firebase.storage.UploadTaskSnapshot.

Also drop a comment explaining a firebase import that #3421 removed
in 2023 as unused. The import only existed to steer these typings.

Fixes #3677

(cherry picked from commit 4c5ba7e)

Reviewers

davideast

davideast approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.