GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |
GeezerVison is showing github.com — fix(schematics): read the signed-in Firebase account on firebase-tools 15.26+ by armando-navarro · Pull Request #3769 · angular/angularfire Conversation
Collaborator
Fixes #3768 firebase-tools 15.26 switches to non-interactive mode when it detects an AI agent, and in that mode Changes
Verification
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsfirebase-tools 15.26 runs non-interactively when it detects an AI agent or when stdin is not a terminal, and in that mode login() returns undefined instead of the signed-in account. `ng add` and `ng deploy` crashed reading `.email` from it. getActiveAccount passes `interactive: true`, which returns the account without a prompt once one is signed in. The `firebase login` and `firebase login:add` commands setup starts get `--interactive` for the same reason. Setup no longer passes its options to login(), since they carry the Angular project name, which firebase-tools rejects as a project id for names like `myApp`. The Quickstart stops telling readers to install firebase-tools 14. Fixes angular#3768
tyler-reitz
approved these changes
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Approving. Confirmed the root cause in firebase-tools 15.28.1 itself: One nit, not blocking:
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Collaborator
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. Uh oh!
There was an error while loading. Please reload this page.
armando-navarro
added a commit
that referenced
this pull request
…3769) firebase-tools 15.26 runs non-interactively when it detects an AI agent or when stdin is not a terminal, and in that mode login() returns undefined instead of the signed-in account. `ng add` and `ng deploy` crashed reading `.email` from it. getActiveAccount passes `interactive: true`, which returns the account without a prompt once one is signed in. The `firebase login` and `firebase login:add` commands setup starts get `--interactive` for the same reason. Setup no longer passes its options to login(), since they carry the Angular project name, which firebase-tools rejects as a project id for names like `myApp`. The Quickstart stops telling readers to install firebase-tools 14, and says what a stopped run leaves behind. Fixes #3768 The Quickstart changes are left out, since docs are not backported. (cherry picked from commit 38dfc3f)
armando-navarro
added a commit
that referenced
this pull request
…#3813) The docs on 21.0.x still install with @angular/fire@next, call 21 a release candidate, and carry the AI-agent note for the firebase-tools 15.26 crash that #3769 fixed on this branch. The 21.0.0 tag is cut from this branch, so its docs should describe the release. The upgrade command keeps @angular/fire unversioned: only the first @angular/ package in an ng update command picks the CLI that runs it. The Node.js note gives the versioned form for updating AngularFire alone.
armando-navarro
added a commit
that referenced
this pull request
…#3814) Same change as #3813 on 21.0.x, carried to main because the public announcements and the rc.1 release notes link the upgrade guide at blob/main, so main's copy must read the same once 21.0.0 is on latest. The AI-agent note goes too: its fix (#3769) has been on main since rc.2. The upgrade command keeps @angular/fire unversioned: only the first @angular/ package in an ng update command picks the CLI that runs it. (cherry picked from commit ca70d4c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
backport: 20.1.x
ProjectsDevelopmentSuccessfully merging this pull request may close these issues. ng add @angular/fire stops with Cannot read properties of undefined (reading 'email') when firebase-tools 15.26+ detects an AI agent
Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |