GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — chore(sample): update the sample app to Angular 22 by armando-navarro · Pull Request #3845 · angular/angularfire Conversation
Collaborator
Checklist
DescriptionCarries
Changes
Behavior to know
Verification
Not exercised: "New animal" (a
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
armando-navarro
added a commit
to armando-navarro/angularfire
that referenced
this pull request
The sample app now has one provideFirebaseApp with initializeBrowserOrServerApp in its shared app.config.ts (angular#3845), so the sentence about its split client and server files no longer holds. Refs angular#3843 Carries sample/ from Angular 21 to 22 with ng update, matching what ng new 22 generates: TypeScript 6, firebase 13, vitest 5, Node 24, provideBrowserGlobalErrorListeners, no explicit zoneless provider and no withIncrementalHydration (both are defaults now), the Eager change detection the migration adds removed again so the components run on the OnPush default. The server app is now built by initializeBrowserOrServerApp, which reads the ID token from the request context and releases the server app after the render. The old factory never released it. Calls to functions AngularFire does not wrap sit outside runInInjectionContext, with a comment on each, so the sample shows where the injection context is needed and where it is not. security.allowedHosts gains localhost: Angular 22 answers 400 to any host not on the list, so the built server could not be run locally. Both lockfiles regenerated with npm 10. Refs angular#3669
armando-navarro
force-pushed
the
sample-angular-22
branch
from
63c5d39 to
ab768c8
Compare
armando-navarro
marked this pull request as ready for review
tyler-reitz
approved these changes
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Approving. I rebuilt the tarball and ran the sample's Optional nit:
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsUh oh!
There was an error while loading. Please reload this page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
comp: other
ProjectsDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |