GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: fire dragStart event only when a cursor is moved (#283) by nomeaning777 · Pull Request #284 · angular-split/angular-split

Conversation

@nomeaning777

@nomeaning777 nomeaning777 commented Dec 10, 2020

Copy link
Copy Markdown
Contributor

Currently, angular-split doesn't always fire dragEnd event after dragStart instead it fires gutterClick / gutterDblClick when the cursor/touch position is not moved.
In this PR, dragStart is delayed until initial cursor/touch position move to avoid such inconsistency.

fixes #283

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nomeaning777
fix: fire dragStart event only when a cursor is moved (angular-split#283
ec5a968 
)
@beeman

beeman commented Dec 10, 2020

Copy link
Copy Markdown
Contributor

@nomeaning777 this looks awesome, great job! I'm going to give it a quick local run this weekend to make sure I fully understand the changes, and it will be deployed with v5! 🎉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@beeman
beeman merged commit 00a6755 into angular-split:main Dec 18, 2020
@angular-split angular-split locked and limited conversation to collaborators Feb 18, 2021
@Jefiozie

Jefiozie commented Jan 24, 2024

Copy link
Copy Markdown
Contributor

@all-contributors please add @nomeaning777 for code.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

dragEnd event not sent when single-clicking gutter

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@nomeaning777 @beeman @Jefiozie
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.