Description

pweissenbacher

opened on Dec 7, 2020

Issue body actions

Describe the bug
Package version: 4.0.0
When dragging the gutter, the events "dragStart/dragEnd" are working fine.
But when soley clicking the gutter, the dragStart event is fired, but the dragEnd event is not.

To Reproduce
Look at the small Stackblitz example (dragging not updating, but events fired as described)
StackBlitz Dev Mode
StackBlitz App Mode

Activity

1. pweissenbacher

   added

   bug

   on Dec 7, 2020
2. beeman

   added

   help wanted

   on Dec 7, 2020
3. nomeaning777 commented on Dec 8, 2020

   

   nomeaning777

   on Dec 8, 2020

   Contributor

   More actions

   In the current implementation, the component fires dragStart when a mouse button is pressed.
   However, it fires dragEnd only when the mouse cursor is moved and the button is released.
   If mouse cursor is not moved, it emits gutterClick/gutterDblClick.
   https://github.com/angular-split/angular-split/blob/main/projects/angular-split/src/lib/component/split.component.ts#L709

   I think it is better to fire dragStart event only when a mouse button is pressed and the cursor is moved.
   I will be happy to create a PR if this breaking change is acceptable.
4. beeman commented on Dec 8, 2020

   

   beeman

   on Dec 8, 2020

   Contributor

   More actions

   @nomeaning777 I'm definitely interested in a PR that adds support for this (or maybe, fixes the bug that dragStart gets emitted when nothing gets dragged).

   It would be awesome if it could be implemented with minimal amount of code changes, and add some cypress tests that prove the behavior.

   I think we can publish that in a major version, maybe it can go into v5.
5. nomeaning777

   added 3 commits that reference this issue on Dec 9, 2020

   fix: fire dragStart event only when a cursor is moved (angular-split#283

   9dc0184

   fix: fire dragStart event only when a cursor is moved (angular-split#283

   9f33c5e

   fix: fire dragStart event only when a cursor is moved (angular-split#283

   ec5a968
6. beeman

   closed this as completedin #284on Dec 18, 2020
7. beeman

   added a commit that references this issue on Dec 18, 2020

   fix: fire dragStart event only when a cursor is moved (#283)

   00a6755
8. beeman commented on Dec 18, 2020

   

   beeman

   on Dec 18, 2020

   Contributor

   More actions

   This fix is released in version 5.0.0 thanks to @nomeaning777 🎉

   https://stackblitz.com/edit/angular-ivy-xhc5bj?file=src/app/app.component.html
9. angular-split

   locked and limited conversation to collaborators on Feb 18, 2021

Issue actions