GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: correctly type the size property by beeman · Pull Request #289 · angular-split/angular-split

Conversation

@beeman

@beeman beeman commented Dec 18, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fix #220

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
lf-novelt, ethnoplex, KyDenZ, Klaster1, laggage, and teuf22 reacted with thumbs up emoji
All reactions
  • 👍 6 reactions
@beeman
fix: correctly type the size property
f3f84c7
@beeman
beeman force-pushed the beeman/fix-size-params branch from 0a1a65f to f3f84c7 Compare December 18, 2020 09:44
@beeman beeman mentioned this pull request Mar 1, 2021
Incorrect @Input size typing when strictTemplates is enabled #220
Closed
lf-novelt
lf-novelt reviewed Mar 1, 2021
View reviewed changes
Comment thread projects/angular-split/src/lib/interface.ts
y: number
}

export type IAreaSize = number | '*'

@lf-novelt lf-novelt Mar 1, 2021

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird to prefix a type (not an interface) with the capital I prefix that means Interface :P

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@beeman beeman Mar 1, 2021

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point @lf-novelt - I'm not a fan of the I for interfaces either, it's more a matter of keeping consistency.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@lf-novelt

lf-novelt commented Mar 1, 2021

Copy link
Copy Markdown
Contributor

Thanks for the PR.
Can you set the description of the first post to the following please?
Fix #220
beeman reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@108174

108174 commented Jun 12, 2021

Copy link
Copy Markdown

Has this been merged yet? Still having the issue; using the $any('*') workaround for now
Klaster1 and teuf22 reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@beeman

beeman commented Jun 12, 2021

Copy link
Copy Markdown
Contributor Author

Has this been merged yet? Still having the issue; using the $any('*') workaround for now

Sorry, little time for maintenance currently. I will see if I can cut a release and include this change.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@KyDenZ

KyDenZ commented Jan 28, 2022

Copy link
Copy Markdown

Can you merge this modification?
Klaster1 and laggage reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@angular-split angular-split deleted a comment from zbagley Apr 14, 2022
@laggage

laggage commented Aug 5, 2022

Copy link
Copy Markdown

Is there a plan to release this PR?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Harpush

Harpush commented Dec 2, 2022

Copy link
Copy Markdown
Collaborator

@beeman The PR seems good... Any reason to wait with it?
teuf22, laggage, wubaodong, alexmelk, Klaster1, jason-lee-rav, and wf9a5m75 reacted with thumbs up emoji
All reactions
  • 👍 7 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@wf9a5m75

wf9a5m75 commented Apr 15, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

For the people who are waiting this PR. This PR is still waiting for some reasons.
Meanwhile, you can do with [size]="$any('*').

For example:

<as-split
  [direction]="'horizontal'"
  [unit]="'pixel'"
>
  
   <as-split-area
     [size]="280"
     [maxSize]="280">
    A
   </as-split-area>
   
   <as-split-area
     [size]="$any('*')">
    B
   </as-split-area>

</as-split>
Klaster1 and lf-novelt reacted with thumbs up emoji
All reactions
  • 👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
marksvc added a commit to sillsdev/web-xforge that referenced this pull request Aug 29, 2023
@marksvc
SF-2028c shrink audio area up if hide text
45067aa 
In situations where we hide the text, intending just for the audio
player to be used, the patch makes the text+audio area have a maximum
size of the height needed by the audio player (109 px), to just show
the audio player. The audio area can still be made smaller to move it
up out of the way.

In the case where we do not hide the text, and whether or not there is
audio, still we show the question area as a smaller area near the
bottom of the screen, with the Scripture text area using most of the
available space. Though I made the question area slightly bigger than
it was before so the "Add answer" button has a greater chance of being
fully visible (170 px).

Using `$any('*')` workaround until this PR is merged:
angular-split/angular-split#289
After that, just `'*'` can be used.
@marksvc marksvc mentioned this pull request Aug 29, 2023
SF-2028 Hide community checking text when requested sillsdev/web-xforge#1967
Merged
marksvc added a commit to sillsdev/web-xforge that referenced this pull request Aug 30, 2023
@marksvc
SF-2028c shrink audio area up if hide text
6670933 
In situations where we hide the text, intending just for the audio
player to be used, the patch makes the text+audio area have a maximum
size of the height needed by the audio player (109 px), to just show
the audio player. The audio area can still be made smaller to move it
up out of the way.

In the case where we do not hide the text, and whether or not there is
audio, still we show the question area as a smaller area near the
bottom of the screen, with the Scripture text area using most of the
available space. Though I made the question area slightly bigger than
it was before so the "Add answer" button has a greater chance of being
fully visible (170 px).

Using `$any('*')` workaround until this PR is merged:
angular-split/angular-split#289
After that, just `'*'` can be used.
marksvc added a commit to sillsdev/web-xforge that referenced this pull request Aug 31, 2023
@marksvc
SF-2028c shrink audio area up if hide text
63e6fc1 
In situations where we hide the text, intending just for the audio
player to be used, the patch makes the text+audio area have a maximum
size of the height needed by the audio player (109 px), to just show
the audio player. The audio area can still be made smaller to move it
up out of the way.

In the case where we do not hide the text, and whether or not there is
audio, still we show the question area as a smaller area near the
bottom of the screen, with the Scripture text area using most of the
available space. Though I made the question area slightly bigger than
it was before so the "Add answer" button has a greater chance of being
fully visible (170 px).

Using `$any('*')` workaround until this PR is merged:
angular-split/angular-split#289
After that, just `'*'` can be used.
@beeman beeman mentioned this pull request Sep 2, 2023
feat: support angular compiler strict templates #353
Merged
@beeman beeman closed this Sep 3, 2023
@beeman
beeman deleted the beeman/fix-size-params branch September 4, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@lf-novelt lf-novelt lf-novelt left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incorrect @Input size typing when strictTemplates is enabled

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@beeman @lf-novelt @108174 @KyDenZ @laggage @Harpush @wf9a5m75
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.