GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: introduce eslint and remove tslint closes (#374) by Jefiozie · Pull Request #382 · angular-split/angular-split

Conversation

@Jefiozie

@Jefiozie Jefiozie commented Jan 23, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

With this PR we introduce Eslint with the default Angular Eslint rules and a extra rule for the public member. I've added the linting rule in "warn" state so that we see it but it is not impacting anything. Lint check is added when commiting and when running CI.

Closes #374

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Jefiozie added 8 commits January 23, 2024 08:44
@Jefiozie
feat: introduce eslint to the project
f902941
@Jefiozie
fix: resolve linting rules
d828577
@Jefiozie
Merge remote-tracking branch 'origin/main' into feat/eslint
5feb495
@Jefiozie
fix: resolve linting rules for app and exclude nx
a491b2d
@Jefiozie
fix: resolve linting rules for app
13a4158
@Jefiozie
fix: resolve type issues
3ef5959
@Jefiozie
feat: introduce explicit member rule
dfa682d
@Jefiozie
chore: update git hook to run lint commiting
921015e
@Jefiozie
Jefiozie force-pushed the feat/eslint branch 2 times, most recently from c482517 to e18c260 Compare January 23, 2024 09:19
SanderElias
SanderElias approved these changes Jan 23, 2024
View reviewed changes
@Jefiozie
Jefiozie force-pushed the feat/eslint branch 2 times, most recently from 9e8da3e to a6d8e12 Compare January 23, 2024 09:28
@Jefiozie
chore: set husky as a prepare step so that hook will be handled
a6d8e12
@Jefiozie
Jefiozie marked this pull request as ready for review January 23, 2024 09:29
@Jefiozie
Jefiozie requested a review from Harpush January 23, 2024 09:31
SanderElias
SanderElias approved these changes Jan 23, 2024
View reviewed changes
@Jefiozie Jefiozie changed the title Feat/eslint feat: introduce eslint and remove tslint closes (#374) Jan 23, 2024
@Jefiozie Jefiozie mentioned this pull request Jan 23, 2024
feat: improve CI workflow #388
Merged
@Jefiozie
Jefiozie merged commit b8431f4 into angular-split:main Jan 23, 2024
@Jefiozie
Jefiozie deleted the feat/eslint branch January 23, 2024 15:17
This was referenced Jan 24, 2024
chore(main): release angular-split 17.2.0 #389
Closed
chore(main): release angular-split 17.2.0 #418
Merged
@github-actions github-actions Bot mentioned this pull request Feb 26, 2024
chore(main): release 15.1.0 #431
Closed
@github-actions github-actions Bot mentioned this pull request May 2, 2024
chore(main): release 15.1.0 #437
Closed
@fjaguado fjaguado mentioned this pull request Jul 19, 2024
[Snyk] Upgrade angular-split from 17.1.1 to 17.2.0 systelab/systelab-components#890
Closed
@github-actions github-actions Bot mentioned this pull request Oct 19, 2024
chore(main): release 15.1.0 #457
Closed
@github-actions github-actions Bot mentioned this pull request Nov 4, 2024
chore(main): release 18.0.0 #466
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SanderElias SanderElias SanderElias approved these changes
@Harpush Harpush Awaiting requested review from Harpush

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Switching from TSLint to ESLint

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Jefiozie @SanderElias
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.