GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: improve CI workflow by Jefiozie · Pull Request #388 · angular-split/angular-split

Conversation

@Jefiozie

@Jefiozie Jefiozie commented Jan 23, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

In this Pull Request (PR), we are excited to introduce several enhancements to our Continuous Integration (CI) process. Below is an overview of the newly added functionalities:

Compliance: This action aids in handling incoming PRs that may require adjustments beyond just code.

Note: The Compliance check is currently failing due to permission issues. This will be resolved once the changes are merged.

Contributions: Utilizing the @all-contributors add bot, this feature automatically posts acknowledgments in the most recent issues and PRs for each contributor's efforts.

Build: This action builds both the application and the library.

Lint: This step lints the application and library, ensuring code quality and consistency.

Test: We've implemented an end-to-end (e2e) testing process.

Dependency Review: This function scans dependencies to identify and report on vulnerable packages.

License: Scheduled to run annually (or manually), this action updates the License file with the current year.

Release-Please: This automates the release process based on specific types of git commits, such as fixes or new features.

Additionally, we have integrated commitlint to validate the commits made on the clients, enhancing the overall quality and consistency of our commit history.

this will close: #375 and #376

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Harpush reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@Jefiozie Jefiozie closed this Jan 23, 2024
@Jefiozie Jefiozie reopened this Jan 23, 2024
@Jefiozie
Jefiozie force-pushed the firststepsCi branch from 0f330db to 8904051 Compare January 23, 2024 13:43
@Jefiozie
Jefiozie requested a review from SanderElias January 23, 2024 14:04
@Jefiozie

Jefiozie commented Jan 23, 2024

Copy link
Copy Markdown
Contributor Author

Lint will also fail as the PR #382 is not yet merged

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Jefiozie Jefiozie changed the title feat: introduce complaince check for PR feat: improve CI workflows Jan 23, 2024
SanderElias
SanderElias approved these changes Jan 23, 2024
View reviewed changes

@SanderElias SanderElias left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me
1 nit tho, I think we should move all CI?Cd to node 20 now

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@Jefiozie

Jefiozie commented Jan 23, 2024

Copy link
Copy Markdown
Contributor Author

Looks good to me 1 nit tho, I think we should move all CI?Cd to node 20 now

Should we also build, lint test etc on the main branch?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Jefiozie Jefiozie changed the title feat: improve CI workflows feat: improve CI workflow Jan 24, 2024
Jefiozie and others added 11 commits January 24, 2024 07:23
@Jefiozie
feat: introduce complaince check for PR
173cdad
@Jefiozie
feat: introduce automatic all-contributors when a pr is created it wi…
2ca70eb
…ll automatic make a contribution branch
@Jefiozie
chore: move complaince to correct folder
d697169
@Jefiozie
fix: set permissions
17d9760
@Jefiozie
fox: outline
38f8f22
@Jefiozie
Update complaince.yml
befd4ad
@Jefiozie
ci: add license and dependency review
dd4680b
@Jefiozie
ci: add release-please
5c3cb97
@Jefiozie
ci: add build pipeline
a191ded
@Jefiozie
ci: add lint pipeline
bc61ff3
@Jefiozie
ci: fix typo in build pipeline
29d0885
@Jefiozie
Jefiozie force-pushed the firststepsCi branch from 72c2f72 to 2e781a0 Compare January 24, 2024 06:33
Jefiozie added 3 commits January 24, 2024 07:34
@Jefiozie
ci: add commitlint
2e781a0
@Jefiozie
ci: use node 20
fc29204
@Jefiozie
ci: indencint for release-please
99c9552
@Jefiozie

Jefiozie commented Jan 24, 2024

Copy link
Copy Markdown
Contributor Author

Looks good to me 1 nit tho, I think we should move all CI?Cd to node 20 now

@SanderElias I've changed it to node 20.x

SanderElias reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Jefiozie
Jefiozie requested a review from SanderElias January 24, 2024 06:41
@SanderElias

SanderElias commented Jan 24, 2024

Copy link
Copy Markdown
Contributor

Can this be merged now?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Jefiozie added 2 commits January 24, 2024 07:42
@Jefiozie
ci: update setup node action
85d86f6
@Jefiozie
ci: fix indenting in contributors
0330032
@Jefiozie

Jefiozie commented Jan 24, 2024

Copy link
Copy Markdown
Contributor Author

@SanderElias when all actions are green, except complaince, Yes!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@Jefiozie
ci: remove duplicate linting
3bbc3b3
@SanderElias
SanderElias merged commit 4d0608d into angular-split:main Jan 24, 2024
@Jefiozie

Jefiozie commented Jan 24, 2024

Copy link
Copy Markdown
Contributor Author

@all-contributors please add @SanderElias for maintenance.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@allcontributors allcontributors Bot mentioned this pull request Jan 24, 2024
docs: add sanderelias as a contributor for maintenance #412
Merged
@allcontributors

allcontributors Bot commented Jan 24, 2024

Copy link
Copy Markdown
Contributor

@Jefiozie

I've put up a pull request to add @SanderElias! 🎉

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SanderElias SanderElias Awaiting requested review from SanderElias

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Optimizing CI Pipeline: Comprehensive Build, Lint, Test, and Automated Release Workflow

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Jefiozie @SanderElias
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.