GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: read and set nas.backup.incremental.enabled for the test zone by jmsperu · Pull Request #13960 · apache/cloudstack

Conversation

@jmsperu

@jmsperu jmsperu commented Aug 24, 2026

Copy link
Copy Markdown
Collaborator

Description

nas.backup.incremental.enabled is a zone-scoped setting, but test_backup_recovery_nas.py read and updated it without a zoneid, so a zone override in the test environment would make the suite read the wrong value (and restore the wrong one in tearDownClass). This passes zoneid=cls.zone.id on the read and on both updates, the same way test_backup_recovery_veeam.py handles zone-scoped settings.

Noted by the Copilot review on the 4.22 backport #13877; this is the main-side fix so both branches stay in sync.

Types of changes

  • Test change only (no functional change)

How Has This Been Tested?

Python syntax check; the change is limited to three Marvin calls in setUpClass/tearDownClass.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jmsperu
test: read and set nas.backup.incremental.enabled for the test zone
b442b73 
nas.backup.incremental.enabled is a zone-scoped setting, but
test_backup_recovery_nas.py read and updated it without a zoneid, so a zone
override in the test environment would make the suite read the wrong value.
Pass zoneid=cls.zone.id on the read and on both updates, as the other backup
smoke tests do for zone-scoped settings.

Noted by the Copilot review on the 4.22 backport (apache#13877).

Signed-off-by: James Peru <[email protected]>
@boring-cyborg boring-cyborg Bot added component:integration-test Python Warning... Python code Ahead! labels Aug 24, 2026
@codecov

codecov Bot commented Aug 24, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 19.73%. Comparing base (4e4a26b) to head (b442b73).

Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #13960      +/-   ##
============================================
- Coverage     19.73%   19.73%   -0.01%     
+ Complexity    19956    19954       -2     
============================================
  Files          6371     6371              
  Lines        575765   575765              
  Branches      70478    70478              
============================================
- Hits         113642   113632      -10     
- Misses       449766   449779      +13     
+ Partials      12357    12354       -3
Flag Coverage Δ
uitests 3.41% <ø> (ø)
unittests 21.01% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@DaanHoogland DaanHoogland added this to CloudStack Testing Aug 25, 2026
@github-project-automation github-project-automation Bot moved this to Backlog in CloudStack Testing Aug 25, 2026
@abh1sar

abh1sar commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

@blueorangutan package
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@blueorangutan

blueorangutan commented Aug 27, 2026

Copy link
Copy Markdown

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@abh1sar

abh1sar commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

@jmsperu
This is not an issue worth fixing.
The config is zone scoped, but it can be set at the global level as well.
If the zone scoped value is set then that will take precedence over the global value.
This is same with all config. I don't think this requires fixing. The test works with global scope value.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@blueorangutan

blueorangutan commented Aug 27, 2026

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19000
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@DaanHoogland DaanHoogland moved this from Backlog to Ready in CloudStack Testing Sep 1, 2026
@DaanHoogland

DaanHoogland commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

@blueorangutan test
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@blueorangutan

blueorangutan commented Sep 1, 2026

Copy link
Copy Markdown

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@DaanHoogland

DaanHoogland commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

@jmsperu This is not an issue worth fixing. The config is zone scoped, but it can be set at the global level as well. If the zone scoped value is set then that will take precedence over the global value. This is same with all config. I don't think this requires fixing. The test works with global scope value.

@abh1sar I think it is worth to make the test more robust, this way an operator can decide to run it standalon in a zone.
abh1sar reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@DaanHoogland DaanHoogland assigned Pearl1594 Sep 1, 2026
@blueorangutan

blueorangutan commented Sep 2, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

[SF] Trillian test result (tid-16862)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 56112 seconds
Marvin logs: [archive removed]
Smoke tests completed. 156 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
DaanHoogland
DaanHoogland approved these changes Sep 2, 2026
View reviewed changes

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm, imnsho no more than smoke test needed.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@DaanHoogland

DaanHoogland commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

do you approve @abh1sar ?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@abh1sar

abh1sar commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

do you approve @abh1sar ?

yes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
abh1sar
abh1sar approved these changes Sep 8, 2026
View reviewed changes

@abh1sar abh1sar left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
weizhouapache
weizhouapache approved these changes Sep 8, 2026
View reviewed changes
@DaanHoogland
DaanHoogland merged commit 92946e1 into apache:main Sep 8, 2026
25 of 27 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@github-project-automation github-project-automation Bot moved this from Ready to Done in CloudStack Testing Sep 8, 2026
weizhouapache pushed a commit to weizhouapache/cloudstack that referenced this pull request Oct 12, 2026
@jmsperu @weizhouapache
improve test to read and set nas.backup.incremental.enabled for the t…
a397e42 
…est zone (apache#13960)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes
@weizhouapache weizhouapache weizhouapache approved these changes
@abh1sar abh1sar abh1sar approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@Pearl1594 Pearl1594

Labels

component:integration-test Python Warning... Python code Ahead!

Projects

CloudStack Testing
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@jmsperu @abh1sar @blueorangutan @DaanHoogland @weizhouapache @Pearl1594
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.