GeezerVison is showing github.com — vmware-base: fix template copy from secondary to primary by weizhouapache · Pull Request #13977 · apache/cloudstack
Conversation
Description
This PR fixes #7572 #12036 #12610 (hopefully)
Types of changes
- Breaking change (fix or feature that would cause existing functionality to change)
- New feature (non-breaking change which adds functionality)
- Bug fix (non-breaking change which fixes an issue)
- Enhancement (improves an existing feature and functionality)
- Cleanup (Code refactoring and cleanup, that may add test cases)
- Build/CI
- Test (unit or integration test code)
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
- BLOCKER
- Critical
- Major
- Minor
- Trivial
Screenshots (if appropriate):
How Has This Been Tested?
Tested with vm template http://dl.openvm.eu/cloudstack/macchinina/x86_64/
Without this PR: filesystem error (90% possibility)

With this PR: all are good (100%)

How did you try to break this feature and the system with this change?
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
codecov
Bot
commented
Aug 26, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
❌ Patch coverage is 0% with 56 lines in your changes missing coverage. Please review.
✅ Project coverage is 16.52%. Comparing base (6136ac9) to head (0cb82c3).
⚠️ Report is 25 commits behind head on 4.20.
Additional details and impacted files
@@ Coverage Diff @@
## 4.20 #13977 +/- ##
============================================
+ Coverage 16.32% 16.52% +0.20%
- Complexity 13556 13872 +316
============================================
Files 5669 5669
Lines 501399 506098 +4699
Branches 60902 62858 +1956
============================================
+ Hits 81847 83635 +1788
- Misses 410390 413124 +2734
- Partials 9162 9339 +177
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18991
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
@weizhouapache a [SL] Trillian-Jenkins test job (ol9 mgmt + vmware-80u3) has been kicked to run smoke tests
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
[SF] Trillian Build Failed (tid-16833)
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
[SF] Trillian Build Failed (tid-16845)
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
[SF] Trillian test result (tid-16846)
Environment: vmware-80u3 (x2), zone: Advanced Networking with Mgmt server ol9
Total time taken: 76722 seconds
Marvin logs: [archive removed]
Smoke tests completed. 136 look OK, 5 have errors, 0 did not run
Only failed and skipped tests results shown below:
| Test |
Result |
Time (s) |
Test File |
| test_DeployVmAntiAffinityGroup_in_project |
Error |
145.95 |
test_affinity_groups_projects.py |
| test_DeployVmAntiAffinityGroup |
Error |
62.40 |
test_affinity_groups.py |
| test_03_deploy_and_scale_kubernetes_cluster |
Failure |
44.16 |
test_kubernetes_clusters.py |
| test_08_upgrade_kubernetes_ha_cluster |
Failure |
0.09 |
test_kubernetes_clusters.py |
| test_01_non_strict_host_anti_affinity |
Failure |
182.45 |
test_nonstrict_affinity_group.py |
| test_02_non_strict_host_affinity |
Error |
105.52 |
test_nonstrict_affinity_group.py |
| ContextSuite context=TestMigrateVMStrictTags>:setup |
Error |
0.00 |
test_vm_strict_host_tags.py |
| test_01_restore_vm_strict_tags_success |
Error |
3605.57 |
test_vm_strict_host_tags.py |
| test_02_restore_vm_strict_tags_failure |
Error |
9.03 |
test_vm_strict_host_tags.py |
| test_01_scale_vm_strict_tags_success |
Error |
18.05 |
test_vm_strict_host_tags.py |
| test_02_scale_vm_strict_tags_failure |
Error |
3604.19 |
test_vm_strict_host_tags.py |
| test_01_deploy_vm_on_specific_host_without_strict_tags |
Error |
17.07 |
test_vm_strict_host_tags.py |
| test_02_deploy_vm_on_any_host_without_strict_tags |
Error |
3605.73 |
test_vm_strict_host_tags.py |
| test_03_deploy_vm_on_specific_host_with_strict_tags_success |
Error |
3.89 |
test_vm_strict_host_tags.py |
| test_04_deploy_vm_on_any_host_with_strict_tags_success |
Error |
5.78 |
test_vm_strict_host_tags.py |
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some comments and test results don’t look too good. But that last bit is probably in the vmware test suite itself.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
|
thanks @DaanHoogland
the smoke tests results are consistent with the 4.23.0.0 RC3, I think there is no regression caused by it, we could run together with #13628
will update the PR as you suggested.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19040
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-80u3) has been kicked to run smoke tests
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
[SF] Trillian Build Failed (tid-16863)
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-80u3) has been kicked to run smoke tests
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
[SF] Trillian Build Failed (tid-16867)
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19436
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
@weizhouapache a [SL] Trillian-Jenkins test job (ol9 mgmt + vmware-80u3) has been kicked to run smoke tests
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
weizhouapache reacted with thumbs up emoji
|
[SF] Trillian test result (tid-17096)
Environment: vmware-80u3 (x2), zone: Advanced Networking with Mgmt server ol9
Total time taken: 69177 seconds
Marvin logs: [archive removed]
Smoke tests completed. 133 look OK, 8 have errors, 0 did not run
Only failed and skipped tests results shown below:
| Test |
Result |
Time (s) |
Test File |
| test_01_native_to_native_network_migration |
Error |
53.60 |
test_migration.py |
| test_02_native_to_native_vpc_migration |
Error |
20.06 |
test_migration.py |
| test_nic_secondaryip_add_remove |
Error |
24.74 |
test_multipleips_per_nic.py |
| test_nested_virtualization_vmware |
Error |
25.43 |
test_nested_virtualization.py |
| test_network_acl |
Error |
8.36 |
test_network_acl.py |
| test_01_verify_ipv6_network |
Error |
20.94 |
test_network_ipv6.py |
| test_01_verify_ipv6_network |
Error |
20.94 |
test_network_ipv6.py |
| test_03_network_operations_on_created_vm_of_otheruser |
Error |
2.61 |
test_network_permissions.py |
| test_03_network_operations_on_created_vm_of_otheruser |
Error |
2.61 |
test_network_permissions.py |
| test_04_deploy_vm_for_other_user_and_test_vm_operations |
Failure |
1.38 |
test_network_permissions.py |
| ContextSuite context=TestNetworkPermissions>:teardown |
Error |
1.45 |
test_network_permissions.py |
| test_delete_account |
Error |
23.13 |
test_network.py |
| test_delete_network_while_vm_on_it |
Error |
2.63 |
test_network.py |
| test_delete_network_while_vm_on_it |
Error |
2.63 |
test_network.py |
| test_deploy_vm_l2network |
Error |
2.64 |
test_network.py |
| test_deploy_vm_l2network |
Error |
2.64 |
test_network.py |
| test_l2network_restart |
Error |
3.76 |
test_network.py |
| test_l2network_restart |
Error |
3.76 |
test_network.py |
| ContextSuite context=TestL2Networks>:teardown |
Error |
4.88 |
test_network.py |
| ContextSuite context=TestPortForwarding>:setup |
Error |
13.68 |
test_network.py |
| ContextSuite context=TestPublicIP>:setup |
Error |
13.39 |
test_network.py |
| test_reboot_router |
Error |
7.62 |
test_network.py |
| test_releaseIP |
Error |
7.49 |
test_network.py |
| test_releaseIP_using_IP |
Error |
7.47 |
test_network.py |
| ContextSuite context=TestRouterRules>:setup |
Error |
14.70 |
test_network.py |
| test_01_deployVMInSharedNetwork |
Failure |
1.29 |
test_network.py |
| test_02_verifyRouterIpAfterNetworkRestart |
Failure |
1.09 |
test_network.py |
| test_03_destroySharedNetwork |
Failure |
1.10 |
test_network.py |
| ContextSuite context=TestSharedNetwork>:teardown |
Error |
2.20 |
test_network.py |
| test_01_deployVMInSharedNetwork |
Failure |
1.35 |
test_network.py |
| ContextSuite context=TestSharedNetworkWithConfigDrive>:teardown |
Error |
2.43 |
test_network.py |
| test_10_reboot_cpvm_forced |
Error |
17.56 |
test_ssvm.py |
| test_12_destroy_cpvm |
Error |
7.29 |
test_ssvm.py |
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
[SF] Trillian test result (tid-17096) Environment: vmware-80u3 (x2), zone: Advanced Networking with Mgmt server ol9 Total time taken: 69177 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13977-t17096-vmware-80u3.zip Smoke tests completed. 133 look OK, 8 have errors, 0 did not run Only failed and skipped tests results shown below:
Although there are lots of errors, the test test_routers_network_ops passed without any issue
pr13977-t17096-vmware-80u3/MarvinLogs/test_routers_network_ops_TZIU9G # cat results.txt
Test redundant router internals ... === TestName: test_01_isolate_network_FW_PF_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: test_02_isolate_network_FW_PF_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: test_01_RVR_Network_FW_PF_SSH_default_routes_egress_true | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: test_02_RVR_Network_FW_PF_SSH_default_routes_egress_false | Status : SUCCESS ===
ok
Test redundant router internals ... === TestName: test_03_RVR_Network_check_router_state | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 5 tests in 1312.511s
OK
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
@weizhouapache a [SL] Trillian-Jenkins test job (ol9 mgmt + vmware-80u3) has been kicked to run smoke tests
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
[SF] Trillian test result (tid-17115)
Environment: vmware-80u3 (x2), zone: Advanced Networking with Mgmt server ol9
Total time taken: 136430 seconds
Marvin logs: [archive removed]
Smoke tests completed. 113 look OK, 28 have errors, 0 did not run
Only failed and skipped tests results shown below:
| Test |
Result |
Time (s) |
Test File |
| ContextSuite context=TestClusterDRS>:setup |
Error |
0.00 |
test_cluster_drs.py |
| test_CRUD_operations_userdata |
Error |
1517.48 |
test_register_userdata.py |
| test_deploy_vm_with_registered_userdata |
Error |
5.86 |
test_register_userdata.py |
| test_deploy_vm_with_registered_userdata_with_override_policy_allow |
Error |
6.07 |
test_register_userdata.py |
| test_deploy_vm_with_registered_userdata_with_override_policy_append |
Error |
5.88 |
test_register_userdata.py |
| test_deploy_vm_with_registered_userdata_with_override_policy_deny |
Error |
5.92 |
test_register_userdata.py |
| test_deploy_vm_with_registered_userdata_with_params |
Error |
5.51 |
test_register_userdata.py |
| test_link_and_unlink_userdata_to_template |
Error |
5.77 |
test_register_userdata.py |
| test_user_userdata_crud |
Error |
5.78 |
test_register_userdata.py |
| ContextSuite context=TestResetVmOnReboot>:setup |
Error |
0.00 |
test_reset_vm_on_reboot.py |
| ContextSuite context=TestRAMCPUResourceAccounting>:setup |
Error |
0.00 |
test_resource_accounting.py |
| test_03_register_template |
Error |
1.09 |
test_resource_names.py |
| ContextSuite context=TestRestoreVM>:setup |
Error |
0.00 |
test_restore_vm.py |
| ContextSuite context=TestRouterDHCPHosts>:setup |
Error |
0.00 |
test_router_dhcphosts.py |
| ContextSuite context=TestRouterDHCPOpts>:setup |
Error |
0.00 |
test_router_dhcphosts.py |
| ContextSuite context=TestVolumes>:setup |
Error |
1512.75 |
test_volumes.py |
| ContextSuite context=TestRouterDns>:setup |
Error |
0.00 |
test_router_dns.py |
| ContextSuite context=TestRouterDnsService>:setup |
Error |
0.00 |
test_router_dnsservice.py |
| ContextSuite context=TestRouterIpTablesPolicies>:setup |
Error |
0.00 |
test_routers_iptables_default_policy.py |
| ContextSuite context=TestVPCIpTablesPolicies>:setup |
Error |
0.00 |
test_routers_iptables_default_policy.py |
| ContextSuite context=TestMigrateVMStrictTags>:setup |
Error |
0.00 |
test_vm_strict_host_tags.py |
| ContextSuite context=TestRestoreVMStrictTags>:setup |
Error |
0.00 |
test_vm_strict_host_tags.py |
| ContextSuite context=TestScaleVMStrictTags>:setup |
Error |
0.00 |
test_vm_strict_host_tags.py |
| ContextSuite context=TestVMDeploymentPlannerStrictTags>:setup |
Error |
0.00 |
test_vm_strict_host_tags.py |
| ContextSuite context=TestIsolatedNetworks>:setup |
Error |
0.00 |
test_routers_network_ops.py |
| ContextSuite context=TestRedundantIsolateNetworks>:setup |
Error |
0.00 |
test_routers_network_ops.py |
| ContextSuite context=TestRouterServices>:setup |
Error |
0.00 |
test_routers.py |
| test_01_scale_vm |
Error |
1.30 |
test_scale_vm.py |
| test_02_scale_vm_negative_offering_disable_scaling |
Error |
1.22 |
test_scale_vm.py |
| test_03_scale_vm_negative_vm_disable_scaling |
Error |
1.23 |
test_scale_vm.py |
| test_04_scale_vm_with_user_account |
Error |
8.98 |
test_scale_vm.py |
| test_05_scale_vm_dont_allow_disk_offering_change |
Error |
1.30 |
test_scale_vm.py |
| ContextSuite context=TestServiceOfferings>:setup |
Error |
1513.34 |
test_service_offerings.py |
| test_04_deploy_vnf_appliance |
Error |
311.23 |
test_vnf_templates.py |
| ContextSuite context=TestSetSourceNatIp>:setup |
Error |
0.00 |
test_set_sourcenat.py |
| ContextSuite context=TestSnapshotRootDisk>:setup |
Error |
0.00 |
test_snapshots.py |
| ContextSuite context=TestSnapshotStandaloneBackup>:setup |
Error |
0.00 |
test_snapshots.py |
| test_01_list_sec_storage_vm |
Failure |
0.03 |
test_ssvm.py |
| test_03_ssvm_internals |
Failure |
0.03 |
test_ssvm.py |
| test_05_stop_ssvm |
Failure |
0.03 |
test_ssvm.py |
| test_07_reboot_ssvm |
Failure |
0.03 |
test_ssvm.py |
| test_09_reboot_ssvm_forced |
Failure |
0.04 |
test_ssvm.py |
| test_11_destroy_ssvm |
Failure |
0.03 |
test_ssvm.py |
| ContextSuite context=TestIpv6Vpc>:setup |
Error |
0.00 |
test_vpc_ipv6.py |
| ContextSuite context=TestVMWareStoragePolicies>:setup |
Error |
0.00 |
test_storage_policy.py |
| test_01_create_template |
Error |
1.12 |
test_templates.py |
| test_CreateTemplateWithDuplicateName |
Error |
149.97 |
test_templates.py |
| test_02_create_template_with_checksum_sha1 |
Error |
65.47 |
test_templates.py |
| test_03_create_template_with_checksum_sha256 |
Error |
65.46 |
test_templates.py |
| test_04_create_template_with_checksum_md5 |
Error |
65.49 |
test_templates.py |
| test_05_create_template_with_no_checksum |
Error |
65.45 |
test_templates.py |
| ContextSuite context=TestTemplates>:setup |
Error |
145.07 |
test_templates.py |
| ContextSuite context=TestISOUsage>:setup |
Error |
0.00 |
test_usage.py |
| test_01_template_usage |
Error |
1.13 |
test_usage.py |
| test_01_volume_usage |
Error |
74.73 |
test_usage.py |
| ContextSuite context=TestVAppsVM>:setup |
Error |
1515.81 |
test_vm_life_cycle.py |
| test_10_attachAndDetach_iso |
Failure |
1510.51 |
test_vm_life_cycle.py |
| ContextSuite context=TestVPCRedundancy>:setup |
Error |
0.00 |
test_vpc_redundant.py |
| ContextSuite context=TestVPCNics>:setup |
Error |
0.00 |
test_vpc_router_nics.py |
| ContextSuite context=TestRVPCSite2SiteVpn>:setup |
Error |
0.00 |
test_vpc_vpn.py |
| ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup |
Error |
0.00 |
test_vpc_vpn.py |
| ContextSuite context=TestVpcRemoteAccessVpn>:setup |
Error |
0.00 |
test_vpc_vpn.py |
| ContextSuite context=TestVpcSite2SiteVpn>:setup |
Error |
0.00 |
test_vpc_vpn.py |
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + vmware-80u3) has been kicked to run smoke tests
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
[SF] Trillian test result (tid-17122)
Environment: vmware-80u3 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 62968 seconds
Marvin logs: [archive removed]
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
| Test |
Result |
Time (s) |
Test File |
| test_03_live_migrate_VM_with_two_data_disks |
Error |
68.24 |
test_vm_life_cycle.py |
| test_08_migrate_vm |
Error |
57.30 |
test_vm_life_cycle.py |
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
ACSHomeBot
commented
Nov 1, 2026
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
|
Accepted: package kvm G for 0cb82c3b551d.
Planned: RPM + DEB, KVM SystemVM.
Status: Completed. Packaging results.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Packaging results:
| Result |
Artifact |
Platform |
Build Time |
| PASS |
RPM |
EL (EL8/9/10) |
25 min |
| PASS |
DEB |
Ubuntu, Debian |
18 min |
Test packages are available at:
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
@rastopato has also updated #12610 (reply in thread):
Well, I tried Ubuntu 20.04, 22.04, 24.04 and rhel 9.6.
But just simple deployment, login and try to run some random commands.
There was no problem with any of these.
I think it is good to merge
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
weizhouapache
added a commit
to weizhouapache/cloudstack
that referenced
this pull request
Nov 5, 2026
* vmware-base: fix template copy from secondary to primary
* vmware-base: refactoring
* test: revert curl commands to wget in test_routers_network_ops (PR 13977)
Revert test_routers_network_ops.py back to wget commands after fixing underlying
macchina VM file system corruption issue.
Context:
- Previous commit changed wget to curl due to libpcre.so.1 library error in macchina VMs
- Error was: 'wget: /usr/lib/libpcre.so.1 is not an ELF file'
- Root cause: file system corruption during template copy from secondary to primary storage
- Fix: PR 13977 (vmware-base: fix template copy from secondary to primary) resolves the issue
- This revert verifies wget is working correctly again after the underlying fix
Changes:
- Replace 'curl -v -m 1 -o index.html -sL www.google.com' back to 'wget -t 1 -T <timeout> www.google.com'
- Affects TestRedundantIsolateNetworks and TestIsolatedNetworks test classes
- Apply timeout values of 5 or 1 second depending on test context
weizhouapache
added a commit
to shapeblue/cloudstack
that referenced
this pull request
Nov 5, 2026
* vmware-base: fix template copy from secondary to primary
* vmware-base: refactoring
* test: revert curl commands to wget in test_routers_network_ops (PR 13977)
Revert test_routers_network_ops.py back to wget commands after fixing underlying
macchina VM file system corruption issue.
Context:
- Previous commit changed wget to curl due to libpcre.so.1 library error in macchina VMs
- Error was: 'wget: /usr/lib/libpcre.so.1 is not an ELF file'
- Root cause: file system corruption during template copy from secondary to primary storage
- Fix: PR 13977 (vmware-base: fix template copy from secondary to primary) resolves the issue
- This revert verifies wget is working correctly again after the underlying fix
Changes:
- Replace 'curl -v -m 1 -o index.html -sL www.google.com' back to 'wget -t 1 -T <timeout> www.google.com'
- Affects TestRedundantIsolateNetworks and TestIsolatedNetworks test classes
- Apply timeout values of 5 or 1 second depending on test context
weizhouapache
added a commit
to weizhouapache/cloudstack
that referenced
this pull request
Nov 12, 2026
* vmware-base: fix template copy from secondary to primary
* vmware-base: refactoring
* test: revert curl commands to wget in test_routers_network_ops (PR 13977)
Revert test_routers_network_ops.py back to wget commands after fixing underlying
macchina VM file system corruption issue.
Context:
- Previous commit changed wget to curl due to libpcre.so.1 library error in macchina VMs
- Error was: 'wget: /usr/lib/libpcre.so.1 is not an ELF file'
- Root cause: file system corruption during template copy from secondary to primary storage
- Fix: PR 13977 (vmware-base: fix template copy from secondary to primary) resolves the issue
- This revert verifies wget is working correctly again after the underlying fix
Changes:
- Replace 'curl -v -m 1 -o index.html -sL www.google.com' back to 'wget -t 1 -T <timeout> www.google.com'
- Affects TestRedundantIsolateNetworks and TestIsolatedNetworks test classes
- Apply timeout values of 5 or 1 second depending on test context
Reviewers
+1 more reviewer
Reviewers whose approvals may not affect merge requirements
Uh oh!
There was an error while loading. Please reload this page.
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|