GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — findbugs UC useless condition by DaanHoogland · Pull Request #490 · apache/cloudstack

Conversation

@DaanHoogland

@DaanHoogland DaanHoogland commented Jun 19, 2015

Copy link
Copy Markdown
Contributor

not sure what findbugs means yet, is it negating the if-condition against the assert?
This should at least turn both warnings into one.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@DaanHoogland
findbugs UC useless condition
90b9e93 
  not sure what findbugs means yet, but this should at least turn both
  warnings into one.
yadvr
yadvr reviewed Jun 19, 2015
View reviewed changes
Comment thread engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java

@yadvr yadvr Jun 19, 2015

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this assert necessary ;)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@DaanHoogland DaanHoogland Jun 19, 2015

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was done like this in two places by Alena. I had the idea she had a goal in mind. the assert is only nice in debug situation so her goal was probably educating developers. the following if negates it, kind of completely.

@bhaisaab it is also a test of the new findbugs messages that i am leaving it in for. Shall we?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@asfgit asfgit closed this in c45c9bf Jun 19, 2015
@asfbot

asfbot commented Jun 19, 2015

Copy link
Copy Markdown

cloudstack-pull-requests #505 FAILURE
Looks like there's a problem with this pull request
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kishankavala pushed a commit to kishankavala/cloudstack that referenced this pull request Jun 25, 2015
@DaanHoogland @kishankavala
findbugs UC useless condition not sure what findbugs means yet, but t…
da58788 
…his should at least turn both warnings into one.

Signed-off-by: Daan Hoogland <[email protected]>

This closes apache#490
@DaanHoogland
DaanHoogland deleted the findbugs-UC branch August 3, 2015 20:43
yadvr pushed a commit that referenced this pull request Jan 20, 2021
@davidjumani @yadvr
compute: Simplifying Deploy VM Wizard (#499)
1647c55 
Fixes #490
Fixes #491

Signed-off-by: Rohit Yadav <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@DaanHoogland @asfbot @yadvr
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.