GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — dhcp/dns offload feature config dirve changes for vm migration by jayapalu · Pull Request #568 · apache/cloudstack

Conversation

@jayapalu

@jayapalu jayapalu commented Jul 9, 2015

Copy link
Copy Markdown
Contributor

Added vm migration changes for config drive.
Added integration test for this.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Jayapal added 4 commits July 8, 2015 15:12
Jayapal
CLOUDSTACK-8324: Added migration changes for config drive
638885a
Jayapal
Removed using config drive label from the uservmservice
56f2b9c
Jayapal
Fixed config key in multiple places
50efd1d
Jayapal
CLOUDSTACK-8324: Added integration tests for dhcp dns offload feature
05d8ba1
@asfbot

asfbot commented Jul 9, 2015

Copy link
Copy Markdown

cloudstack-pull-rats #22 SUCCESS
This pull request looks good
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@asfbot

asfbot commented Jul 9, 2015

Copy link
Copy Markdown

cloudstack-pull-requests #717 UNSTABLE
Looks like there's a problem with this pull request
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sanju1010
sanju1010 reviewed Jul 9, 2015
View reviewed changes
Comment thread test/integration/component/test_dhcp_dns_offload.py

@sanju1010 sanju1010 Jul 9, 2015

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to comment this if DHCP Server is available in the shared network broadcast domain while running tests. Looks good to me.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kishankavala

kishankavala commented Jul 9, 2015

Copy link
Copy Markdown
Contributor

Looks good to me.
Commented on older PR earlier.
PR #552 can be removed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@asfgit asfgit closed this in 3df847d Jul 10, 2015
@asfbot

asfbot commented Jul 10, 2015

Copy link
Copy Markdown

Daan Hoogland on [email protected] replies:
I don't see two LGTM on this one. What happened?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sateesh-chodapuneedi

sateesh-chodapuneedi commented Jul 10, 2015

Copy link
Copy Markdown
Member

@DaanHoogland

I think there are 2 LGTM on this one - from @sanju1010 & @kishankavala

sanju1010 added a note a day ago
Need to comment this if DHCP Server is available in the shared network broadcast domain while >running tests. Looks good to me.

kishankavala commented a day ago
Looks good to me.
Commented on older PR earlier.
PR #552 can be removed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@asfbot

asfbot commented Jul 10, 2015

Copy link
Copy Markdown

Daan Hoogland on [email protected] replies:
my bad, I would like to see "$LGTM" (as in on the start of a line),
though. This looks like a comment at first.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
yadvr pushed a commit that referenced this pull request Jan 20, 2021
Hoang Nguyen @yadvr
npm: Build and packaging improvements (#568)
64d95fb 
* remove unused plugins and minimizer js

* update dependencies

* fix build, update dependencies

* using lazy_use components

* add additional components

* optimization: lazy loading i18n locales

Signed-off-by: Rohit Yadav <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@jayapalu @asfbot @kishankavala @sateesh-chodapuneedi @sanju1010
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.