GeezerVison

cloudstack-pull-rats #539 SUCCESS
This pull request looks good

Hi @bvbharatk

couple of questions regarding your changes:

1. There was also an issue with VPC VRs, which was reported/fixed here -> https://issues.apache.org/jira/browse/CLOUDSTACK-8685. Have you seen this issue? Does your change affects the VPC VR (single/redundant)?
2. How did you test it? Could you please share the results of your test reports?

I would expect at least the following tests to be executed:

• component/test_vpc_routers.py
• component/test_routers.py
• component/test_vpc_redundant.py
• smoke/test_vm_life_cycle.py

Thanks in advance.

Cheers,
Wilder

cloudstack-pull-analysis #473 SUCCESS
This pull request looks good

Hi @bvbharat ,

Any news on this PR?

Cheers,
Wilder

Hi @wilderrodrigues

will update once i am done testing against vpc networks.

Okay, @bvbharat ... thanks for the update. :)

Cheers,
Wilder

cloudstack-pull-rats #564 SUCCESS
This pull request looks good

cloudstack-pull-rats #565 SUCCESS
This pull request looks good

cloudstack-pull-analysis #499 SUCCESS
This pull request looks good

cloudstack-pull-analysis #500 UNSTABLE
Looks like there's a problem with this pull request

cloudstack-pull-rats #568 ABORTED

cloudstack-pull-analysis #504 ABORTED

After applying patch, was able to create VPC successfully.
LGTM.
Sub-process optimization is good to have. This PR will unblock the VPC creation.

2015-09-11 15:59:15,169 DEBUG c.c.a.t.Request Seq 297-1810728525179650071: Processing: { Ans: , MgmtId: 233845178473044, via: 297, Ver: v1, Flags: 110, [{"com.cloud.agent.api.StartAnswer":{"vm":{"id":34,"name":"r-34-VM","type":"DomainRouter","cpus":1,"minSpeed":500,"maxSpeed":500,"minRam":268435456,"maxRam":268435456,"arch":"x86_64","os":"Debian GNU/Linux 5.0 (64-bit)","platformEmulator":"Debian GNU/Linux 5","bootArgs":" vpccidr=10.5.1.0/24 domain=cs2cloud.internal dns1=4.2.2.2 template=domP name=r-34-VM eth0ip=169.254.1.43 eth0mask=255.255.0.0 type=vpcrouter disable_rp_filter=true baremetalnotificationsecuritykey=s67s-w0ooifUaTiCWhF24OUfj8JSRhTKTs6N-2rlWY2tkkPo-F0nZOv1lKTIyXXs0ir4vv0hatiUHFaddZxiDw baremetalnotificationapikey=c9SUcsu8zctnSQmy43yhQB0HJM2HTDsRjEXd85s9IJOobOBRLaGZBa22vDH4IozJpIW8PHXVAFWu_W9qtdvYIA host=10.147.28.47 port=8080","enableHA":true,"limitCpuUse":false,"enableDynamicallyScaleVm":false,"vncPassword":"UOXbgiNACZU3NN8Rv6uvNg","vncAddr":"10.147.28.43","params":{},"uuid":"4da3b373-17bc-4b4a-8b34-f32459faf341","disks":[{"data":{"org.apache.cloudstack.storage.to.VolumeObjectTO":{"uuid":"5e291e11-8043-4b67-9b41-aa55e71e8236","volumeType":"ROOT","dataStore":{"org.apache.cloudstack.storage.to.PrimaryDataStoreTO":{"uuid":"954526cd-d0f1-4a9e-b80a-902baad3faa2","id":3,"poolType":"Filesystem","host":"10.147.28.43","path":"/var/lib/libvirt/images","port":0,"url":"Filesystem://10.147.28.43/var/lib/libvirt/images/?ROLE=Primary&STOREUUID=954526cd-d0f1-4a9e-b80a-902baad3faa2"}},"name":"ROOT-34","size":3145728000,"path":"5e291e11-8043-4b67-9b41-aa55e71e8236","volumeId":34,"vmName":"r-34-VM","accountId":2,"format":"QCOW2","provisioningType":"THIN","id":34,"deviceId":0,"hypervisorType":"KVM"}},"diskSeq":0,"path":"5e291e11-8043-4b67-9b41-aa55e71e8236","type":"ROOT","_details":{"managed":"false","storagePort":"0","storageHost":"10.147.28.43","volumeSize":"3145728000"}}],"nics":[{"deviceId":0,"networkRateMbps":-1,"defaultNic":false,"pxeDisable":true,"nicUuid":"588f728c-9de8-4b04-8fd4-7b03226c9ef2","uuid":"4c825977-669f-4777-9a44-a312952321c8","ip":"169.254.1.43","netmask":"255.255.0.0","gateway":"169.254.0.1","mac":"0e:00:a9:fe:01:2b","broadcastType":"LinkLocal","type":"Control","isSecurityGroupEnabled":false}]},"result":true,"wait":0}},{"com.cloud.agent.api.check.CheckSshAnswer":{"result":true,"wait":0}},{"com.cloud.agent.api.GetDomRVersionAnswer":{"templateVersion":"Cloudstack Release 4.6.0 Sun Jul 26 22:08:05 UTC 2015","scriptsVersion":"d6222468f4f35d173be74954631b18d2\n","result":true,"details":"Cloudstack Release 4.6.0 Sun Jul 26 22:08:05 UTC 2015&d6222468f4f35d173be74954631b18d2\n","wait":0}},{"com.cloud.agent.api.PlugNicAnswer":{"result":true,"details":"success","wait":0}},{"com.cloud.agent.api.routing.GroupAnswer":{"results":["null - success: null","null - success: [INFO] update_config.py :: Processing incoming file => ip_associations.json\n[INFO] Processing JSON file ip_associations.json\n"],"result":true,"wait":0}},{"com.cloud.agent.api.Answer":{"result":true,"details":"Nothing to do","wait":0}},{"com.cloud.agent.api.NetworkUsageAnswer":{"routerName":"r-34-VM","bytesSent":0,"bytesReceived":0,"result":true,"wait":0}}] }

This one was merged, but it wasn't closed since something went wrong with the commit to master.

@remibergsma, help? Any idea on how to close this PR?

@wido you can ask @bvbharatk to close it or add the message
This closes #784
to a related PR commit (same functionality, I would suggest)

@bvbharatk or @ke4qqq something went wrong with the auto-close (wasn't merged properly) Could either of you close this PR please? Thanks!

commit ids
b66dcda
1a02773

This broke VPC default gateways, which was fixed in #738. Looking into a solution now.