GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — CLOUDSTACK-8928: While adding VMs to LB rule, default NIC IP is always displayed rather than the IP corresponding to the NIC where LB is being created by nitin-maharana · Pull Request #903 · apache/cloudstack

Conversation

@nitin-maharana

@nitin-maharana nitin-maharana commented Oct 1, 2015

Copy link
Copy Markdown
Contributor

While calling the listNics API, instead of sending the default nic id as parameter, it should send the network id as a parameter.

So, replaced that nicid parameter as networkid parameter.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sebgoa

sebgoa commented Oct 5, 2015

Copy link
Copy Markdown
Member

@nitin-maharana Any automated tests for this ? if not, can you spend the time to write some. thanks
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nitin-maharana

nitin-maharana commented Oct 7, 2015

Copy link
Copy Markdown
Contributor Author

@Runseb I think there is no automated tests for this. I will try to write one. Thanks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@remibergsma

remibergsma commented Oct 24, 2015

Copy link
Copy Markdown
Contributor

@nitin-maharana Any update on this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nitin-maharana

nitin-maharana commented Oct 24, 2015

Copy link
Copy Markdown
Contributor Author

@remibergsma I was busy in some other works. Within 3-4 days I will work on this and will give an update. Thank you.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nitin-maharana

nitin-maharana commented Oct 30, 2015

Copy link
Copy Markdown
Contributor Author

Hi @Runseb @remibergsma I don't understand what to test and how to write a test for this. If you have any idea of how to write one, please help me out. Thanks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nitin-maharana
nitin-maharana force-pushed the nitin1 branch from 38d9b6a to 834ab53 Compare October 30, 2015 09:29
Nitin Kumar Maharana @nitin-maharana
CLOUDSTACK-8928: While adding VMs to LB rule, default NIC IP is alway…
834ab53 
…s displayed rather than the IP corresponding to the NIC where LB is being created

While calling the listNics API, instead of sending the default nic id as parameter, it should send the network id as a parameter.
So, replaced that nicid parameter as networkid parameter.
@karuturi

karuturi commented Nov 2, 2015

Copy link
Copy Markdown
Member

great find @nitin-maharana
manually tested the fix
In my setup, I had a vm with two nics
isolated1 - 10.1.1.14 - default
isolated 2 - 10.1.1.187 - non default

When I add a LB rule in network isolated2 for the VM, this is API call before the change and it failed.
screen shot 2015-11-02 at 4 38 35 pm

After the fix, it took the right IP and succeeded.
screen shot 2015-11-02 at 4 49 11 pm

👍 LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@remibergsma

remibergsma commented Nov 2, 2015

Copy link
Copy Markdown
Contributor

Nice small fix, LGTM.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@asfgit
asfgit merged commit 834ab53 into apache:master Nov 2, 2015
asfgit pushed a commit that referenced this pull request Nov 2, 2015
@remibergsma
Merge pull request #903 from nitin-maharana/nitin1
abbdb2e 
CLOUDSTACK-8928: While adding VMs to LB rule, default NIC IP is always displayed rather than the IP corresponding to the NIC where LB is being createdWhile calling the listNics API, instead of sending the default nic id as parameter, it should send the network id as a parameter.

So, replaced that nicid parameter as networkid parameter.

* pr/903:
  CLOUDSTACK-8928: While adding VMs to LB rule, default NIC IP is always displayed rather than the IP corresponding to the NIC where LB is being created

Signed-off-by: Remi Bergsma <[email protected]>
@nitin-maharana

nitin-maharana commented Nov 2, 2015

Copy link
Copy Markdown
Contributor Author

Thanks @karuturi @remibergsma.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nitin-maharana
nitin-maharana deleted the nitin1 branch January 14, 2016 16:48
@nitin-maharana
nitin-maharana restored the nitin1 branch January 14, 2016 16:48
yadvr pushed a commit that referenced this pull request Jan 20, 2021
@davidjumani @yadvr
ui: Allowing user to use local/browser timezone (#903)
8430bed 
Allowing user to use local/browser timezone

Signed-off-by: Rohit Yadav <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@nitin-maharana @sebgoa @remibergsma @karuturi @asfgit
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.