GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix bugs on last step on Wizard zone and Adv Search box by milamberspace · Pull Request #912 · apache/cloudstack

Conversation

@milamberspace

@milamberspace milamberspace commented Oct 5, 2015

Copy link
Copy Markdown
Contributor

Javascript error: Uncaught ReferenceError: _ is not defined
Missing 'l' (to call the _l() function)

Bug introduce by me (#712)

For the zone wizard, the Next button isn't replace by Finish button and the steps don't display in the box.
For the Adv Search box, the label of search button is "submit" instead of "Search" (in en_US localization)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@milamberspace
Fix bugs on last step on Wizard zone and Adv Search box
351ffe1 
Javascript error: Uncaught ReferenceError: _ is not defined
=> Missing 'l' (to call the _l() function)

Bug introduce by me (apache#712)

For the zone wizard, the Next button isn't replace by Finish button and the steps don't display in the box.
For the Adv Search box, the label of search button is "submit" instead of "Search" (in en_US localization)
=
@milamberspace

milamberspace commented Oct 5, 2015

Copy link
Copy Markdown
Contributor Author

@remibergsma
Probably this is a 'minor' blocker bug for the 4.6 release.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@remibergsma

remibergsma commented Oct 5, 2015

Copy link
Copy Markdown
Contributor

@milamberspace Thanks, this we should include indeed. Will try to test in the coming days.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sebgoa

sebgoa commented Oct 5, 2015

Copy link
Copy Markdown
Member

@milamberspace @remibergsma there is a duplicate at #906
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@milamberspace

milamberspace commented Oct 5, 2015

Copy link
Copy Markdown
Contributor Author

@Runseb Good catch!
Thanks @nitin-maharana to fix part of this bugs.
@remibergsma my PR add a bug on Adv search label.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@DaanHoogland

DaanHoogland commented Oct 6, 2015

Copy link
Copy Markdown
Contributor

I tried to run the wizard with this patch applied but the wizard doesn't show 'finished' nor does it finish after pressing 'next' for a final time. I shows a blank screen and then loops back to the beginning of the wizard.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@milamberspace

milamberspace commented Oct 6, 2015

Copy link
Copy Markdown
Contributor Author

@DaanHoogland you need to double-check that the old zoneWizard.js file is changed on you browser (clean cache) and on the tomcat installation (if not a new installation) in work/temp dir. I have a lot of problem to test that because even I clean my browser cache, the tomcat service continue to serve the old zoneWizard.js without the L in the _l() function. Finally I made a full clean installation of CS to validate my fixes.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@milamberspace

milamberspace commented Oct 7, 2015

Copy link
Copy Markdown
Contributor Author

Closed. New PR #915
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@milamberspace milamberspace closed this Oct 7, 2015
@milamberspace milamberspace mentioned this pull request Oct 7, 2015
CLOUDSTACK-8930: Showing blank screen when click 'Next' link in final step of Add Zone wizard. #906
Closed
@DaanHoogland DaanHoogland mentioned this pull request Oct 7, 2015
Pr 906 912 bug zone wizard and adv search popup #915
Merged
yadvr pushed a commit that referenced this pull request Jan 20, 2021
@davidjumani @yadvr
migratewizard: Display error and unfreeze form when api call fails (#912
f0d08c5 
)

Signed-off-by: Rohit Yadav <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@milamberspace @remibergsma @sebgoa @DaanHoogland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.