GeezerVison

…e-common

Move the standalone `native` crate into a root Cargo workspace and extract
shared JNI plumbing (error->exception mapping, Tokio runtime singleton,
StreamingReader) into a new `datafusion-jni-common` crate under `native-common/`.
`native/src/errors.rs` moves to `native-common/src/errors.rs`; the nine native
modules now import error/runtime helpers from `datafusion_jni_common`.

Build glue follows: single root `Cargo.lock`, `.cargo/config.toml` redirects
output to `rust-target/`, Makefile/CI/poms updated to build `--workspace` and
target `-p datafusion-jni`. Core javadoc build commands updated to match.

Pure refactor; no behavior change. First of a 6-PR stack splitting the Spark
DataSource V2 connector work.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>

…on-jni-common

Add [workspace.package] (version, edition, license, repository) to the root
manifest and have both crates inherit it via `*.workspace = true`, so a single
bump re-versions the workspace in lock step.

Make datafusion-jni-common publishable: drop `publish = false` and add a
`description` (crates.io requires it). All its dependencies are registry
crates, so nothing blocks publish. datafusion-jni stays `publish = false`
since it is a JVM-loaded cdylib, not a crates.io library.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>

The `**/META-INF/services/**` and `spark/scaffold/bridge-template/**` RAT
excludes guard files that do not exist until later splits in the stack. They
are dead config here. Re-added in the splits that introduce the files they
cover (META-INF/services in 04-spark-scala-connector, bridge-template in
05-bridge-scaffold).

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>

The `**/*.md` exclude dropped every markdown file repo-wide from license
checking, not just docs. It was redundant (docs are already covered by
`docs/**`) and overly broad. Removing it; RAT still reports 0 unapproved
because the remaining markdown carries valid headers.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>

Add a crate README so the crates.io listing has front-page content, and wire
it in via `readme = "README.md"`. The ASF license header is an HTML comment
(matching dev/release/README.md) so RAT approves it while it stays invisible
in the rendered markdown.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>

Address review feedback on the workspace-foundation PR:

- development.md: trim the repo-layout section to the crates this PR
  actually ships (native, native-common). It was forward-referencing
  spark/, spark/bridge, datafusion-spark-bridge, and examples/native --
  none of which exist until later PRs in the stack -- and called the
  member list "three" while listing four. Later PRs (apache#105/apache#106/apache#107/apache#109)
  carry notes to re-add their own slice when those dirs land.

- rat_exclude_files.txt: the Rust lockfile moved to the workspace root,
  so the stale native/Cargo.lock entry left the root Cargo.lock with no
  RAT exclude for the source-tarball check (check-rat-report.py). Point
  it at Cargo.lock.

- native-common: dedupe the panic-payload downcast -- StreamingReader::next
  now calls errors::panic_message instead of repeating the String/&str
  match inline.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>

The Cargo workspace conversion redirects build output to rust-target/
(via .cargo/config.toml), but the dev/release scripts still built from
native/ and read native/target/release/, which is no longer populated
even when cargo runs inside native/ (config is discovered up-tree).

- build-native-libs.sh / build-release.sh: build from the repo root with
  `-p datafusion-jni` and copy from rust-target/{release,<triple>/release}/.
- verify-release-candidate.sh: run `cargo fmt --all` workspace-wide so the
  new native-common crate is covered (matches CI lint.yml).
- updating-datafusion-version.md: list the workspace.dependencies entries
  that actually exist (datafusion, -proto, -spark, -substrait); drop the
  stray datafusion-ffi reference.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>

No release script or doc describes publishing the Rust crates to
crates.io, and the crate is an internal implementation detail of the
native crates (its README already says the API may change to track
their needs). Match `publish = false` on datafusion-jni so an
accidental `cargo publish` can't push it.

Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>

Copilot AI left a comment

andygrove left a comment