GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

GeezerVison is showing github.com — Always add exception cause (first PR) by hendrikebbers · Pull Request #2250 · bcgit/bc-java

Conversation

hendrikebbers commented Feb 1, 2026

Copy link

Copy Markdown

This PR is based on #2239

The PR does not fix the issue but only changes some first places. Once the PR is merged I will continue by creating PRs for each module.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

hendrikebbers added 2 commits

January 29, 2026 15:20


          passing cause to new exceptions to keep stack trace

f9df574


          Merge branch 'main' into exception-cause

592be57

dghgit commented Mar 4, 2026

Copy link

Copy Markdown

Contributor

The constructor in use was not added till Java 5, we still support Java 4.

If you use org.bouncycastle.util.Exceptions.illegalArgumentException() you'll get the effect you want as well as maintaining the compatibility we need to support.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

dghgit commented May 2, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

This has been applied using the Exceptions class. New behavior is in the version on https://www.bouncycastle.org/betas

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

dghgit closed this

hubot pushed a commit that referenced this pull request


          Added use of Exceptions class to propogate cause, relates to github #…

af79374

…2250

hubot pushed a commit that referenced this pull request


          Added use of Exceptions class to propogate cause, relates to github #…

9a3ce13

…2250

hubot pushed a commit that referenced this pull request


          Added use of Exceptions class to propogate cause for IllegalStateExce…

a08bb94

…ption, relates to github #2250

hubot pushed a commit that referenced this pull request


          Added use of Exceptions class to propogate cause for IOException, rel…

6b169b3

…ates to github #2250

hubot pushed a commit that referenced this pull request


          Added cause to GeneralSecurityException throw, relates to github #2250

eaebef1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.