Description

zhanyan-Ader1y

opened on Nov 29, 2024

Issue body actions

简要描述

在微信支付的 com.github.binarywang.wxpay.config.WxPayConfig#p12ToPem 中, 会尝试获取p12证书. 但尝试性操作却输出了异常堆栈, 是否考虑去掉堆栈的打印?

模块版本情况

• WxJava 模块名: wxpay
• WxJava 版本号: latest

日志

com.github.binarywang.wxpay.exception.WxPayException: 请确保证书文件地址【p12证书】或者内容已配置
	at com.github.binarywang.wxpay.config.WxPayConfig.loadConfigInputStream(WxPayConfig.java:382)
	at com.github.binarywang.wxpay.config.WxPayConfig.p12ToPem(WxPayConfig.java:456)
	at com.github.binarywang.wxpay.config.WxPayConfig.initApiV3HttpClient(WxPayConfig.java:291)

Activity

1. zhanyan-Ader1y

   changed the title [-][尝试获取p12证书] 是否考虑去掉堆栈报错?[/-] [+][尝试获取p12证书] 是否考虑去掉堆栈打印?[/+] on Nov 29, 2024
2. binarywang commented on Nov 29, 2024

   

   binarywang

   on Nov 29, 2024

   Owner

   More actions

   欢迎直接提交代码来展现你的想法
3. binarywang

   linked a pull request that will close this issuebug: #3424 [微信支付]尝试加载p12证书前校验path, 避免path为空时加载失败打印堆栈 #3428on Dec 3, 2024
4. binarywang

   added a commit that references this issue on Dec 3, 2024

   🎨 #3424 【微信支付】加载证书前增加校验，减少不必要的异常日志输出

   3f3c37d
5. binarywang

   closed this as completedin #3428on Dec 3, 2024
6. HaalandCR commented on Dec 10, 2024

   

   HaalandCR

   on Dec 10, 2024

   More actions

   这个pr有问题，本来loadConfigInputStream就是从keyString、keyPath、keyContent三个里面读取inputStream，只要任何一个有值就能读取到。现在加的这个判断导致必须keyPath有值才能走下，只设置keyString或keyContent的情况下直接返回了null，影响使用，并不是所有人都使用keyPath来设置证书
   
7. binarywang

   linked a pull request that will close this issuebug: 公钥预校验时校验 path/content/string #3435on Dec 12, 2024

Issue actions