GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — Added files for sample nightwatch repo by amitsi-bs · Pull Request #1 · browserstack/browserstack-nightwatch-load-testing-sample

Conversation

amitsi-bs commented Feb 10, 2026

Copy link

Copy Markdown

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          added default files

ae0a7a3

amitsi-bs requested a review from a team as a code owner

February 10, 2026 04:27

amitsi-bs requested a review from dheeren-gaud

February 10, 2026 04:27

dheeren-gaud previously approved these changes

Feb 10, 2026

View reviewed changes

amitsi-bs changed the title ~~Added default files~~ Added files for sample nightwatch repo

Feb 11, 2026

MihirR-BS and others added 4 commits

October 27, 2026 19:40


          LTS-5442: run the official CLI, pin Semgrep, patch piscina

- LTS-5486: the README told users to run `npx browserstack-cli load run`,
  but this sample never installs browserstack-node-sdk (which ships the
  browserstack-cli bin), so npx fetched the unrelated third-party
  `browserstack-cli` package from npm with BROWSERSTACK_ACCESS_KEY in the
  environment. Point the README at the official CLI binary download used
  by the Selenium and cucumber-testng samples instead.
- LTS-5502: Semgrep image had no tag (pulled :latest); pin to
  1.166.0@sha256:c180f0c9..., same as the Playwright sample.
- LTS-5492: override piscina 4.9.2 -> 4.9.4 (GHSA-x9g3-xrwr-cwfg,
  GHSA-67c8-pqhq-4rmx).

Co-Authored-By: Claude Opus 5.5 <[email protected]>


          LTS-5442: sync package files with the hardened load-testing-backend copy

90f6f4c

The copy of this sample bundled in load-testing-backend
(sample/sample-nightwatch-repo.zip) was hardened under LTS-4698 with 13
security overrides, but the change never came back to this repo. Take
its package.json and package-lock.json as-is, with the piscina override
raised to ^4.9.4 (LTS-5492). The repo and the bundled zip now ship the
same dependency tree.

Co-Authored-By: Claude Opus 5.5 <[email protected]>


          LTS-5442: rewrite browserstack-load.yml in the CLI schema

8524ff4

The yml carried the backend's internal shape (loadTestName, fileKey,
testScript, language: '', loadProfile: constant, loadProfileStages), which
browserstack-cli rejects as invalid keys. Rewrite it per the CLI's Nightwatch
sample, keeping the same vus / duration / region.

Verified with `browserstack-cli load run`: completed, 1792 requests.

Co-Authored-By: Claude Opus 5.5 <[email protected]>


          Merge pull request #2 from browserstack/LTS-5442-nightwatch-sample-se…

0db4119

…curity

LTS-5442: run the official CLI, pin Semgrep, patch piscina

SaranshBS dismissed dheeren-gaud’s stale review via

0db4119

October 28, 2026 10:30

coderabbitai Bot commented Oct 28, 2026

Copy link

Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Central YAML (base), Organization UI (inherited), Workspace UI (inherited); Enforced overrides: Organization
Review profile: ASSERTIVE
Plan: Advanced
Run ID: 13b7670a-a982-4217-bc3e-bb4316fd80fb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

MihirR-BS added a commit that referenced this pull request

Nov 5, 2026


          LTS-5502: put the Nightwatch sample on main, like the other load-test…

9d4f671

…ing samples

main held only the README and .github/, while the sample itself lived on the
Nightwatch-sample-repo branch (PR #1, by amitsi-bs). That sample is now on main,
next to the digest-pinned Semgrep workflow, in the same shape as the Playwright
and WebdriverIO samples:

- browserstack-load.yml, nightwatch.conf.js, package.json, tests/ and the README
  from Nightwatch-sample-repo (README: the config file is browserstack-load.yml).
  The branch's stray .DS_Store is left out.
- .gitignore (node_modules, log, .DS_Store) and the SC-12282 supply-chain .npmrc
  (ignore-scripts, save-exact, min-release-age, ...) the sibling samples use.
- package-lock.json refreshed within the existing package.json ranges, so the
  sample lands with no high npm-audit finding: nightwatch 3.16.0, mocha 10.8.2,
  brace-expansion / js-yaml / diff / serialize-javascript patches. Two moderates
  (nightwatch -> uuid) remain; npm's only fix is a nightwatch 2.x downgrade.

Co-Authored-By: Claude Opus 5.5 <[email protected]>

MihirR-BS mentioned this pull request

Nov 5, 2026

LTS-5502: pin Semgrep by digest on main, and put the Nightwatch sample on main #3

Merged

MihirR-BS commented Nov 5, 2026

Copy link

Copy Markdown

Contributor

Hi @amitsi-bs, #3 carries this branch's sample onto main (it was conflicting here after the Semgrep pin landed on main), so this PR can be closed once #3 merges.

What #3 changes compared with this branch:

leaves out the stray .DS_Store
README now names browserstack-load.yml correctly
adds the .gitignore and the SC-12282 supply-chain .npmrc the Playwright and WebdriverIO samples use
refreshes package-lock.json within the existing ranges (nightwatch 3.12.3 → 3.16.0, mocha 10.8.2), so the sample lands with no high npm audit finding

The tests and config are unchanged. Leaving the close to you.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Reviewers

dheeren-gaud

dheeren-gaud left review comments

At least 1 approving review is required to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.