GeezerVison is showing github.com — feat!: Remove deprecated CLI flags, `CQ_NO_TELEMETRY`, `install` command and GitHub registry by murarustefaan · Pull Request #23656 · cloudquery/cloudquery
Conversation
Summary
Removes the CLI options that already print deprecation warnings, for the next CLI major release.
BEGIN_COMMIT_OVERRIDE
feat!: Remove deprecated CLI flags, CQ_NO_TELEMETRY, install command and GitHub registry (#23656)
BREAKING-CHANGE: The CLI rejects registry: github in plugin specs. Use registry: cloudquery (requires cloudquery login or CLOUDQUERY_API_KEY), or download the plugin binary and use registry: local.
BREAKING-CHANGE: The top-level cloudquery install command is removed. Use cloudquery plugin install.
BREAKING-CHANGE: The --data-dir and --color flags are removed and fail as unknown flags. Use --cq-dir in place of --data-dir, and delete --color.
BREAKING-CHANGE: The CLI fails at startup when CQ_NO_TELEMETRY is set. Use CQ_TELEMETRY_LEVEL=none.
BREAKING-CHANGE: cloudquery plugin publish no longer accepts the team and plugin name as an argument. Set them in the plugin (for example with plugin.WithTeam in the Go SDK) so the package command writes them to package.json.
END_COMMIT_OVERRIDE
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One low-priority validation issue remains in the platform registry override path, described inline.
The telemetry removal matches the intentional v7 behavior in ATL-670. The Databricks launcher still sets CQ_NO_TELEMETRY=1 and defaults to CLI 6.16.0. Before upgrading it to v7, remove that variable and set CQ_TELEMETRY_LEVEL=none; setting both still fails. Customer deployment and migration status remain unknown.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
|
@@ -9,8 +9,6 @@ import ( |
|
|
|
|
|
func SpecRegistryToPlugin(registry specs.Registry) managedplugin.Registry {
|
|
|
switch registry {
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P3] Validate the platform registry override before conversion
With CQ_PLATFORM_PLUGIN_REGISTRY=github and a source targeting the auto-injected platform destination, RegistryFromString still accepts github. The destination is added after YAML validation, and SetDestinationsAndValidate does not validate its metadata. It therefore reaches this switch and panics with unknown registry "github" instead of returning a migration error. Validate the injected destination metadata or reject github when parsing the override. The previous reproduction passed on the base and panicked on this unchanged head.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This branch has not been deployed
No deployments
Reviewers
disq
Awaiting requested review from disq
disq is a code owner automatically assigned from cloudquery/backend
At least 1 approving review is required to merge this pull request.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.