GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — feat: add a collapse_assistant_steps user preference by ibetitsmike · Pull Request #29416 · coder/coder

Conversation

@ibetitsmike

@ibetitsmike ibetitsmike commented Sep 16, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Stack context

Bottom of a six-PR stack that adds the Collapse assistant steps chat preference (Agents > Settings, off by default). With it on, each turn's consecutive tool-step rows fold into one disclosure: "Worked for 2m 14s (7 steps)" once the turn completes, or a ticking "Working for 12s" while it runs. The stack was split out of #29115 for review size; #29115 now sits at the top with the full feature description and the UAT record.

  1. feat: add a collapse_assistant_steps user preference #29416 feat: add a collapse_assistant_steps user preference (this PR)
  2. feat(site): group assistant steps into working blocks #29417 feat(site): group assistant steps into working blocks
  3. feat(site): add the working block disclosure #29418 feat(site): add the working block disclosure
  4. feat(site): fold assistant steps in the conversation timeline #29419 feat(site): fold assistant steps in the conversation timeline
  5. fix(site): keep streaming text alive inside expanded working blocks #29420 fix(site): keep streaming text alive inside expanded working blocks
  6. feat(site): add the collapse assistant steps chat preference #29115 feat(site): add the collapse assistant steps chat preference

Why

The chat UI reads a per-user boolean to decide whether to fold steps. This layer stores it and exposes it through the preference settings API and SDK.

collapse_assistant_steps follows the existing task_notification_alert_dismissed boolean pattern: a user_configs key with dbauthz wrappers, no migration. The generated API docs and TypeScript types are regenerated, and the frontend preference mocks gain the new required field.

This PR was prepared by Xum, an AI coding agent, on behalf of @ibetitsmike.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ibetitsmike
feat: add a collapse_assistant_steps user preference
87292f1
Adds the per-user preference the chat UI will read to fold assistant tool
steps into a single "Worked for" disclosure. Stores it on users, exposes it
through the preference settings API and SDK, and regenerates the API docs
and TypeScript types.
@github-actions github-actions Bot assigned ibetitsmike Sep 16, 2026
@ibetitsmike
ibetitsmike added this pull request to stack #29421 September 16, 2026 17:10
@ibetitsmike ibetitsmike mentioned this pull request Sep 16, 2026
feat(site): add the collapse assistant steps chat preference #29115
Merged
@ibetitsmike ibetitsmike changed the title mike/collapse assistant steps api feat: add a collapse_assistant_steps user preference Sep 16, 2026
This was referenced Sep 16, 2026
feat(site): group assistant steps into working blocks #29417
Merged
feat(site): add the working block disclosure #29418
Merged
feat(site): fold assistant steps in the conversation timeline #29419
Merged
fix(site): keep streaming text alive inside expanded working blocks #29420
Merged
@ibetitsmike

ibetitsmike commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 16, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-17T09:18:19.092843Z 87292f1 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: 87292f1da3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ibetitsmike
ibetitsmike marked this pull request as ready for review September 17, 2026 09:14
@ibetitsmike
ibetitsmike requested a review from DanielleMaywood as a code owner September 17, 2026 09:14
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Sep 17, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 87292f1da3

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread coderd/database/queries/users.sql Resolved

Uh oh!

There was an error while loading. Please reload this page.

@coderagents

coderagents Bot commented Sep 17, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Documentation Check

New Documentation Needed

  • docs/ai-coder/agents/chat-settings.md - No conceptual page documents the agent chat display preferences in Agents > Settings. This PR ships collapse_assistant_steps on the public GET/PUT /api/v2/users/{user}/preferences endpoints as the API layer of a six-PR stack whose top PR (feat(site): add the collapse assistant steps chat preference #29115) adds the user-visible Collapse assistant steps switch. Per the content guidelines, a new setting that changes user-visible behavior needs a conceptual home, and the multi-PR launch exception allows it to be written now, in the present tense, as part of this stack.
    • Suggested home: a new page under docs/ai-coder/agents/ (for example docs/ai-coder/agents/chat-settings.md) that enumerates the chat display preferences a user configures in Agents > Settings, including Collapse assistant steps (off by default: folds a turn's consecutive tool steps into one disclosure, "Worked for 2m 14s (7 steps)" once the turn completes, or "Working for 12s" while it runs). Add the page to docs/manifest.json and link it from the agent settings navigation.
    • Evidence: searches for collapse_assistant_steps, Collapse assistant steps, collapse assistant steps, thinking_display_mode, code_diff_display_mode, shell_tool_display_mode, agent_chat_send_shortcut, Thinking display, Code diff, Shell tool display, send shortcut, and display mode across docs/ (excluding docs/reference/) all returned no hits, so no page today enumerates these preferences. The API reference pages regenerated in this PR (docs/reference/api/schemas.md, docs/reference/api/users.md) do not close a conceptual-guide gap.

    ⚠️ Checked but no corresponding documentation changes found in this PR


Automated review via Coder Agents

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

DanielleMaywood
DanielleMaywood approved these changes Sep 17, 2026
View reviewed changes
@ibetitsmike
Merge remote-tracking branch 'origin/main' into mike/collapse-assista…
c8ba3e9
…nt-steps-api
@ibetitsmike
ibetitsmike requested a review from a team as a code owner September 26, 2026 21:13
@ibetitsmike
ibetitsmike merged commit 756ffb9 into main Sep 27, 2026
33 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@ibetitsmike
ibetitsmike deleted the mike/collapse-assistant-steps-api branch September 27, 2026 20:15
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 27, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@DanielleMaywood DanielleMaywood DanielleMaywood approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@ibetitsmike ibetitsmike

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ibetitsmike @DanielleMaywood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.