GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test(site/src/pages/AISettingsPage/SpendPage): wait for the cleared spend request by tracyjohnsonux · Pull Request #30132 · coder/coder

Conversation

@tracyjohnsonux

@tracyjohnsonux tracyjohnsonux commented Sep 29, 2026

Copy link
Copy Markdown
Contributor

Fixes the applies and clears the $key filter test from #30128, which failed on main (run) with expected 'openai' to be undefined.

When the filter is cleared, the URL updates before the spend report is requested again. The test checked the last request right after the URL changed, so on a slow runner it still saw the earlier provider_name: "openai" request. It now waits for the request without the filter.

Verified with 5 consecutive local runs of SpendPage.test.tsx, plus pnpm lint:types and biome check.

Generated by Coder Agents on behalf of @tracyjohnsonux.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tracyjohnsonux
test(site/src/pages/AISettingsPage/SpendPage): wait for the cleared s…
21f215b 
…pend request
@github-actions github-actions Bot assigned tracyjohnsonux Sep 29, 2026
@nickvigilante nickvigilante mentioned this pull request Sep 30, 2026
feat: report port-forward sessions as app usage #30156
Merged
ssncferreira
ssncferreira approved these changes Sep 30, 2026
View reviewed changes

@ssncferreira ssncferreira left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch 👍

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ssncferreira
ssncferreira merged commit 95c9dca into main Sep 30, 2026
49 of 50 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@ssncferreira
ssncferreira deleted the spend-filter-test-flake branch September 30, 2026 11:46
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 30, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ssncferreira ssncferreira ssncferreira approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@tracyjohnsonux tracyjohnsonux

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@tracyjohnsonux @ssncferreira
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.