GeezerVison

chatgpt-codex-connector Bot left a comment

EhabY left a comment

EhabY left a comment

`coder port-forward` reported usage with the deprecated
`UpdateWorkspaceUsageContext`. It now uses
`UpdateWorkspaceUsageWithBodyContext` with the agent ID and a new
`port_forward` app name, like `coder ssh` and the VS Code SSH path.

Linear: CLI-31

Rename codersdk.UsageAppNamePortForward to UsageAppNamePortForwarding
(wire value port_forwarding) to match the arbitrary app names RFC's
connection-method name, per review.

Report port-forwarding usage only while a forwarded connection is
open, instead of on a fixed one-minute ticker regardless of activity.
An idle coder port-forward with nothing connected no longer counts as
an active session. A final report runs on shutdown so a session that
starts and ends between ticks is not lost.

Update TestPortForward_UpdateUsage: the no-connection case now expects
no session count, and a new case opens a forwarded connection and
expects a port_forwarding session.

- Register a port_forwarding app family so sessions show as Port
  Forwarding instead of unknown. The deployment banner totals it
  under Other.
- Count only TCP connections. UDP forwards never see EOF, so one
  datagram kept the session active until exit.
- Report once at startup so the last-used bump isn't delayed a minute.
- Move the idle/active decision into portForwardUsage.request and
  table-test it.

Linear: CLI-31

The usage tracker now returns a bool and the reporter builds the SDK request. The reporter's stop func cancels its own context before waiting, so callers no longer need to cancel first.