GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix: bump Go to 1.26.10 and terraform to 1.16.7 (backport 2.35) by sreya · Pull Request #31305 · coder/coder

Conversation

@sreya

@sreya sreya commented Oct 26, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Backport of #31301 to release/2.35 for CVE-2026-111943 (compromised eMudhra intermediate CAs).

  • Go 1.26.9 to 1.26.10.
  • Terraform: install.go 1.14.5 (max 1.14.9) and image/mise 1.15.5 go to 1.16.7; max raised to 1.16.9. No 1.14.x or 1.15.x release carries the Go 1.26.10 rebuild (1.15.9 uses Go 1.25.10, 1.14.9 uses Go 1.25.8).
  • Base image alpine:3.24.1 to alpine:3.24.3, which ships ca-certificates-bundle-20261020-r0.

Verified: rebuilt scripts/Dockerfile.base on this branch (confirmed ca-certificates-bundle-20261020-r0 and Terraform v1.16.7) and go test ./provisioner/terraform/ passes. Local git hooks were skipped at the author's request; CI is the gate.

Also cherry-picks #30922, which renews the SMTP test certificate that expired on 2026-10-18 (TestSMTP fails on every release branch without it).

Generated by Coder Agents on behalf of @sreya.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@sreya
fix: bump Go to 1.26.10 and terraform to 1.16.7 (backport 2.35)
37f532c
Mitigates CVE-2026-111943 (compromised eMudhra intermediate CAs).

- Go 1.26.9 -> 1.26.10, which no longer trusts the compromised
  intermediates.
- Bundled Terraform 1.14.5 (1.15.5 in the image) -> 1.16.7, which is built with Go 1.26.10.
  Older Terraform minor lines did not receive this fix.
- Base image alpine 3.24.1 -> 3.24.3 so it ships ca-certificates-bundle
  20261020-r0.
@github-actions

github-actions Bot commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

Docs preview

📖 View docs preview for docs/install/airgap.md

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot assigned sreya Oct 26, 2026
@sreya
sreya marked this pull request as ready for review October 26, 2026 21:38
@ibetitsmike @sreya
test(coderd/notifications/dispatch/smtptest): renew the expired TLS t…
d1a61d5
…est certificate (#30922)

Renews the SMTP test server certificate in
`coderd/notifications/dispatch/smtptest/fixtures`. It expired on
2026-10-18 at 13:36:08Z, so the TLS cases of `TestSMTP`
(`TLS:_self-signed`, `TLS:_self-signed_+_SNI`, `PLAIN_auth_and_TLS`)
fail in `test-go-pg-17` and `test-go-race-pg` on every PR.

## What changed

- `server.crt`: the committed `server.csr`, re-signed with the committed
CA (`ca.crt`, `ca.key`) and `v3_ext.conf`. It is valid until 2034-07-12,
a day before the CA expires. The key pair, subject, and extensions (SANs
`myserver.local`, `www.myserver.local`, `127.0.0.1`) are unchanged. Only
the serial, the validity, and the signature differ.
- `ca.srl`: the next serial, which the new certificate uses.
- `generate.sh`: it issued the server certificate for 825 days, and
2024-07-15 plus 825 days is 2026-10-18. It now uses 3649 days, a day
less than the CA's 3650.

The command, run in the fixtures directory:

```sh
openssl x509 -req -in server.csr -CA ca.crt -CAkey ca.key -set_serial 0x0330C6D190E3FE649DAFCDA2F4D765E2D29328DF -out server.crt -days 2824 -extfile v3_ext.conf
```

With OpenSSL 3.0.2, `-CAserial ca.srl` issued a random serial and left
`ca.srl` unchanged, so the command sets the next serial explicitly.

## Review focus

Re-signing keeps the CA and the server key, so no other fixture or test
changes. The one choice is the validity: about 7.7 years, ending a day
before the CA.

## Validation

| Check | `main` | This PR |
|---|---|---|
| `openssl x509 -noout -dates` | `notAfter=Oct 18 13:36:08 2026 GMT` |
`notAfter=Jul 12 14:24:37 2034 GMT` |
| `openssl verify -CAfile ca.crt server.crt` | `certificate has expired`
| `server.crt: OK` |
| `go test ./coderd/notifications/dispatch/... -run TestSMTP -count=1` |
the 3 TLS cases fail with `x509: certificate has expired or is not yet
valid` | pass |

`go test ./coderd/notifications/... -count=1` passes, including
`notifications_test.go`, the other user of `smtptest`. A text diff of
the old and new certificates (`openssl x509 -noout -text`) shows only
the serial, the dates, and the signature.

> Xum, an AI agent, opened this PR for @ibetitsmike and wrote this
description.

(cherry picked from commit 1213938)
cjfit
cjfit approved these changes Oct 26, 2026
View reviewed changes

@cjfit cjfit left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@cjfit
cjfit merged commit 0915c92 into release/2.35 Oct 26, 2026
36 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@cjfit
cjfit deleted the backport/31301-to-2.35 branch October 26, 2026 23:14
@github-actions github-actions Bot locked and limited conversation to collaborators Oct 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cjfit cjfit cjfit approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@sreya sreya

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@sreya @cjfit @ibetitsmike
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.