GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — fix: bump gomarkdown/markdown to fix GHSA-cv23-7vc5-jfh7 (backport 2.38) by coder[bot] · Pull Request #31442 · coder/coder Conversation
Contributor
Backport of #31439 to The IronBank VAT scan of
Part of ENT-229 (parent ENT-230). Opened by Superblink on behalf of @droopy4096.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsBumps github.com/gomarkdown/markdown to v0.0.0-20260724235538-61af6e1e6971, the first version with the IsSafeURL short-URL panic fix (GHSA-cv23-7vc5-jfh7 / CVE-2026-102941). Flagged by the IronBank VAT scan of 2.38.3. Refs ENT-229
droopy4096
marked this pull request as ready for review
coder
Bot
requested review from
BobbyHo,
Shelnutt2,
denisra and
jdomeracki-coder
BobbyHo
approved these changes
denisra
pushed a commit
that referenced
this pull request
Bumps `github.com/gomarkdown/markdown` from `v0.0.0-20260411013819-759bbc3e3207` to `v0.0.0-20260724235538-61af6e1e6971`, the first version with the fix for [GHSA-cv23-7vc5-jfh7](GHSA-cv23-7vc5-jfh7) / CVE-2026-102941. `IsSafeURL` sliced the URL before checking its length, so empty or 1 to 2 byte link destinations panic when `Safelink` is on. The IronBank VAT scan of `coder-service-2:2.38.3` flags this (High) in `/opt/coder`. It's justified as Mitigated today because the `safeURL` wrapper and panic recovery in `coderd/render/markdown.go` (#28340) keep it from crashing. The finding stays open until the library is bumped. The 2.38 backport is #31442. This pins the first fixed version, not upstream HEAD, to keep the change small. Upstream has since added CommonMark parser changes and another fix (79e163b, GHSA-c9jw-c68c-f39j, quadratic parse time on unclosed HTML block tags) that isn't in a published advisory yet. That can be a follow-up bump. The `safeURL` workaround is left as is; it can be simplified separately. Verified: `go test ./coderd/render/...` and `go test ./coderd/notifications/ -run Golden` pass. `go mod tidy` changed no other modules. Local git hooks were skipped; CI is the gate. Part of [ENT-229](https://linear.app/codercom/issue/ENT-229) (parent [ENT-230](https://linear.app/codercom/issue/ENT-230)). 2.38 backport: #31442. Opened by Superblink on behalf of @droopy4096. Co-authored-by: coder[bot] <137810501+coder[bot]@users.noreply.github.com> Uh oh!
There was an error while loading. Please reload this page.
denisra
deleted the
superblink/ent-229-gomarkdown-ghsa-cv23-release-238
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
ReviewersUh oh!
There was an error while loading. Please reload this page. AssigneesLabels
cherry-pick/v2.38
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |