GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — chore: Add pubsub by kylecarbs · Pull Request #7 · coder/coder

Conversation

@kylecarbs

@kylecarbs kylecarbs commented Jan 5, 2022

Copy link
Copy Markdown
Member

Exposes new in-memory and PostgreSQL pubsubs. This will be used for negotiating WebRTC connections.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@kylecarbs
chore: Add pubsub
fcea1a5
Exposes new in-memory and PostgreSQL pubsubs. This will be used for negotiating WebRTC connections.
@kylecarbs
kylecarbs requested a review from bryphe-coder January 5, 2022 19:03
@kylecarbs kylecarbs self-assigned this Jan 5, 2022
@kylecarbs
Don't run PostgreSQL tests on non-Linux
5abbbd4
bryphe-coder
bryphe-coder approved these changes Jan 6, 2022
View reviewed changes
@kylecarbs
kylecarbs merged commit 2618ce4 into main Jan 6, 2022
@kylecarbs
kylecarbs deleted the pubsub branch January 6, 2022 14:35
@ericpaulsen ericpaulsen mentioned this pull request Feb 2, 2026
chore(helm): disable liveness probes by default, allow all probe settings #21789
Merged
@mafredri mafredri mentioned this pull request Mar 24, 2026
feat: add automatic database migration recovery to scripts/develop #23466
Merged
mafredri added a commit that referenced this pull request Apr 18, 2026
@mafredri
fix(agent/agentfiles): level-aware indent for inserted splice lines
23c01a6
buildReplacementLines' inserted branch inherited cLead from an
arbitrarily-picked paired content line, so a 4sp LLM search
inserting into a tab-indented or 2sp-indented file emitted the
wrong indent depth. The bug fires on every wrap-in-block,
single-to-multi expansion, or insert-new-block edit where the
caller's search/replace whitespace unit differs from the file's.

Scoped fix:

- detectIndentUnit(lines) scans leading whitespace and returns the
  smallest consistent unit (one tab, or N spaces via GCD). Mixed
  tab+space samples return ("", false).
- translateIndentLevel(rLead, sLead, cLead, searchUnit, fileUnit)
  computes the caller's rep_level relative to their search_base and
  emits the same relative level in the file's unit.
- buildReplacementLines computes searchUnit (from search+rep) and
  fileUnit (from matched) once per splice. Inserted lines (rMid
  non-empty, no search pair) call translateIndentLevel and fall
  back to the previous cLead-inheritance path when detection fails
  or a lead is not a clean multiple of its unit.

Pinned contracts (escape hatch, caller-agrees-with-itself,
empty-body carve-out, ending normalization) all stay green: only
the inserted branch changes, and paired lines take neither of the
new helpers.

Flips the 5 reds in TestEditFiles_FuzzyIndent_InsertionLevelAware
from red to green. Lock #7 and #8 update their expected outputs
to reflect partial post-fix correctness (inserted-line bugs
fixed, middle-substitution leakage still present for follow-up).
Lock #6 (Unwrap) and TestEditFiles_ReplaceAll_FuzzyIndentGap are
middle-substitution cases unchanged by this fix.

Addresses DEREM-11 (diff-aligned pairing known-limitation) for
the pure-insertion class. Middle-substitution level-awareness
remains a separate follow-up tracked by the middle-rewrite locks.
@jakehwll jakehwll mentioned this pull request Apr 21, 2026
feat!: add batch endpoint for adding organization members #24456
Closed
@ibetitsmike ibetitsmike mentioned this pull request Jul 17, 2026
feat(coderd): probe execute tokens in interrupt reconciliation and the execution sweep #27324
Closed
This was referenced Sep 20, 2026
feat: add chat kind discriminator #29614
Closed
feat: add chat tree root, named children, and tree API #29615
Closed
feat(coderd): add search_chat_messages builtin chatd tool #29616
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@bryphe-coder bryphe-coder bryphe-coder approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@kylecarbs kylecarbs

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@kylecarbs @bryphe-coder
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.