GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Dev by xlorne · Pull Request #263 · codingapi/flow-engine

Conversation

@xlorne

@xlorne xlorne commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
xlorne added 5 commits November 10, 2026 10:55
@xlorne
docs: 移除 AGENTS.md 中的禁止自动提交规范
046e83c
删除「禁止自动提交」小节,不再限制未经用户明确要求时的 git commit / push / merge 操作。
@xlorne
fix: 人工节点选中分支后未提示分支内审批人设定 (#259)
bd15fe7
开始节点提交时只对直接下游节点做 APPROVER_SELECT 判断,人工节点选中分支后
matchNextNodes 返回的是分支节点(MANUAL_BRANCH),分支内的审批人设定节点因而
被漏判:前端不弹选人框,流程直接流转到该节点并因无审批人异常(同 #258 根因)。
改为与审批节点提交路径一致,复用 collectApproverSelectNodes 递归收集,
条件分支仍只沿命中分支、分支节点只看首个节点,兼容 #200 / #231 行为。

Closes #259
@xlorne
fix: 撤回时只摘除自身合并关系,避免误删同组其他流程待办 (#260)
b5d38a8
- FlowRecordSaveService:已办结与已撤销记录统一走 removeTodoRecord,合并组只删除本记录的关系并递减合并数量,剩余记录时刷新代表记录
- 删除合并组(组内无剩余记录)时同步清理残余合并关系,避免孤儿数据
- 新增 FlowIssue260MergeRevokeTest:覆盖 a1 撤回后保留 a2、a1 重新提交后合并组恢复为 2 条

Closes #260
@xlorne
Merge pull request #261 from codingapi/feature/issue-260-merge-revoke…
7c18e2d
…-keep-remaining

fix: 撤回时只摘除自身合并关系,避免误删同组其他流程待办 (#260)
@xlorne
Merge pull request #262 from codingapi/feature/issue-259-manual-branc…
3766d75
…h-approver-select

fix: 人工节点选中分支后未提示分支内审批人设定 (#259)
@xlorne
xlorne merged commit e6ae481 into main Nov 10, 2026
4 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@codecov

codecov Bot commented Nov 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.45%. Comparing base (f64785e) to head (3766d75).
⚠️ Report is 61 commits behind head on main.

Files with missing lines Patch % Lines
.../codingapi/flow/service/FlowRecordSaveService.java 82.75% 2 Missing and 3 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #263      +/-   ##
============================================
- Coverage     74.49%   74.45%   -0.05%     
+ Complexity     1808     1806       -2     
============================================
  Files           236      236              
  Lines          7485     7484       -1     
  Branches        865      861       -4     
============================================
- Hits           5576     5572       -4     
- Misses         1487     1490       +3     
  Partials        422      422              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@xlorne
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.