GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||
GeezerVison is showing github.com — fix(pre-commit-hooks): allow empty ranges in 'commitizen-branch' by AdrianDC · Pull Request #2121 · commitizen-tools/commitizen Conversation
Contributor
DescriptionRevival of PR #1209 fix(pre-commit-hooks)!: move 'check' to 'args' for global options
fix(pre-commit-hooks): allow empty ranges in 'commitizen-branch'
fix(check): support first pushes in the 'commitizen-branch' hook
Checklist
Was generative AI tooling used to co-author this PR?
My original PR's commits re-tested by and details updated with: [Claude Opus 5.5] following the guidelines Code Changes
Documentation Changes
Expected BehaviorSteps to Test This Pull RequestAdditional ContextRevival of PR #1209
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsDetails: Global options like '--no-raise' must come before 'check'.
With 'entry: cz check', anything in 'args' comes after it,
so global options cannot be used. Use 'entry: cz' instead.
---
BREAKING CHANGE: Overridden 'args' for the 'commitizen' and
'commitizen-branch' hooks must now start with 'check'
Signed-off-by: Adrian DC <[email protected]>
Details: Force-pushing a branch back to an older commit pushes no new
commits, so the range is empty and 'cz check' blocks the push:
> No commit found with range: '...'
Ignore this error (exit code 3) with '--no-raise 3'.
Invalid commit messages are still rejected.
---
Signed-off-by: Adrian DC <[email protected]>
Details: When a push includes the root commit (first push to an empty
remote, or a new unrelated history), pre-commit does not set
'PRE_COMMIT_FROM_REF' and 'PRE_COMMIT_TO_REF'. The
'commitizen-branch' hook then fails with:
> fatal: ambiguous argument '$PRE_COMMIT_FROM_REF..$PRE_COMMIT_TO_REF'
In this case, check all commits of 'PRE_COMMIT_LOCAL_BRANCH',
since they are all new to the remote.
---
Signed-off-by: Adrian DC <[email protected]>
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
Collaborator
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. This branch has not been deployedNo deployments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ReviewersAt least 1 approving review is required to merge this pull request. Uh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. Uh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. | |||
| You are visitor 01402503 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |