GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(pre-commit-hooks): allow empty ranges in 'commitizen-branch' by AdrianDC · Pull Request #2121 · commitizen-tools/commitizen

Conversation

@AdrianDC

@AdrianDC AdrianDC commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Description

Revival of PR #1209

fix(pre-commit-hooks)!: move 'check' to 'args' for global options

Details: Global options like '--no-raise' must come before 'check'.
With 'entry: cz check', anything in 'args' comes after it,
so global options cannot be used. Use 'entry: cz' instead.

BREAKING CHANGE: Overridden 'args' for the 'commitizen' and
'commitizen-branch' hooks must now start with 'check'

fix(pre-commit-hooks): allow empty ranges in 'commitizen-branch'

Details: Force-pushing a branch back to an older commit pushes no new
commits, so the range is empty and 'cz check' blocks the push:

No commit found with range: '...'
Ignore this error (exit code 3) with '--no-raise 3'.
Invalid commit messages are still rejected.

fix(check): support first pushes in the 'commitizen-branch' hook

Details: When a push includes the root commit (first push to an empty
remote, or a new unrelated history), pre-commit does not set
'PRE_COMMIT_FROM_REF' and 'PRE_COMMIT_TO_REF'. The
'commitizen-branch' hook then fails with:

fatal: ambiguous argument '$PRE_COMMIT_FROM_REF..$PRE_COMMIT_TO_REF'
In this case, check all commits of 'PRE_COMMIT_LOCAL_BRANCH',
since they are all new to the remote.

Checklist

  • I have read the contributing guidelines

Was generative AI tooling used to co-author this PR?

  • Yes (please specify the tool below)

My original PR's commits re-tested by and details updated with: [Claude Opus 5.5] following the guidelines

Code Changes

  • Add test cases to all the changes you introduce
  • Run uv run poe all locally to ensure this change passes linter check and tests
  • Manually test the changes:
    • Verify the feature/bug fix works as expected in real-world scenarios
    • Test edge cases and error conditions
    • Ensure backward compatibility is maintained
    • Document any manual testing steps performed
  • Update the documentation for the changes

Documentation Changes

  • Run uv run poe doc locally to ensure the documentation pages renders correctly
  • Check and fix any broken links (internal or external)

Expected Behavior

Steps to Test This Pull Request

Additional Context

Revival of PR #1209

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
AdrianDC added 3 commits November 8, 2026 14:00
@AdrianDC
fix(pre-commit-hooks)!: move 'check' to 'args' for global options
51ada02
Details: Global options like '--no-raise' must come before 'check'.
         With 'entry: cz check', anything in 'args' comes after it,
         so global options cannot be used. Use 'entry: cz' instead.
---

BREAKING CHANGE: Overridden 'args' for the 'commitizen' and
'commitizen-branch' hooks must now start with 'check'

Signed-off-by: Adrian DC <[email protected]>
@AdrianDC
fix(pre-commit-hooks): allow empty ranges in 'commitizen-branch'
16a1b9e
Details: Force-pushing a branch back to an older commit pushes no new
         commits, so the range is empty and 'cz check' blocks the push:
> No commit found with range: '...'
         Ignore this error (exit code 3) with '--no-raise 3'.
         Invalid commit messages are still rejected.
---

Signed-off-by: Adrian DC <[email protected]>
@AdrianDC
fix(check): support first pushes in the 'commitizen-branch' hook
836b32a
Details: When a push includes the root commit (first push to an empty
         remote, or a new unrelated history), pre-commit does not set
         'PRE_COMMIT_FROM_REF' and 'PRE_COMMIT_TO_REF'. The
         'commitizen-branch' hook then fails with:
> fatal: ambiguous argument '$PRE_COMMIT_FROM_REF..$PRE_COMMIT_TO_REF'
         In this case, check all commits of 'PRE_COMMIT_LOCAL_BRANCH',
         since they are all new to the remote.
---

Signed-off-by: Adrian DC <[email protected]>
@github-actions github-actions Bot added pr-status: wait-for-review type: bug labels Nov 8, 2026
@codecov

codecov Bot commented Nov 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.22%. Comparing base (f690817) to head (836b32a).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2121      +/-   ##
==========================================
- Coverage   98.28%   98.22%   -0.07%     
==========================================
  Files          61       61              
  Lines        2864     2866       +2     
==========================================
  Hits         2815     2815              
- Misses         49       51       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@woile
woile requested review from Lee-W and bearomorphism November 9, 2026 10:15
@bearomorphism

bearomorphism commented Nov 10, 2026

Copy link
Copy Markdown
Collaborator

It seems that the pipeline validation failed on windows env. @AdrianDC could you check? Thanks.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@GnunuX

GnunuX commented Nov 10, 2026

Copy link
Copy Markdown

It seems that the pipeline validation failed on windows env. @AdrianDC could you check? Thanks.

The pipeline fails on Windows regardless of changes in the pull requests. Another pull request offers a proposed solution: #2119 (comment)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Lee-W Lee-W Awaiting requested review from Lee-W
@bearomorphism bearomorphism Awaiting requested review from bearomorphism

At least 1 approving review is required to merge this pull request.

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

pr-status: wait-for-review type: bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@AdrianDC @bearomorphism @GnunuX
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.