GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(pre-commit-hooks)!: allow empty ranges in 'commitizen-branch' by AdrianDC · Pull Request #1209 · commitizen-tools/commitizen

Conversation

@AdrianDC

@AdrianDC AdrianDC commented Aug 15, 2024

Copy link
Copy Markdown
Contributor

Description

fix(pre-commit-hooks)!: move 'check' to 'args' for global options

Details: 'args: [...]' is not able to access '-nr NO_RAISE' global
arguments for example from a arguments configuration

fix(pre-commit-hooks)!: allow empty ranges in 'commitizen-branch'

Details: Pushing the same history from 'develop' to 'staging' for
example fails because range 'origin/HEAD..HEAD' is empty

No commit found with range: 'origin/HEAD..HEAD'

Checklist

  • Add test cases to all the changes you introduce
  • Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

Error No commit found with range: 'origin/HEAD..HEAD' not raised

Steps to Test This Pull Request

Push same history to develop then staging

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AdrianDC
AdrianDC requested review from Lee-W, noirbizarre and woile as code owners August 15, 2024 20:28
@github-actions github-actions Bot added the pr-status: wait-for-review label Aug 15, 2024
@codecov

codecov Bot commented Aug 15, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (v4@737c24c). Learn more about missing BASE report.

Additional details and impacted files 
@@          Coverage Diff          @@
##             v4    #1209   +/-   ##
=====================================
  Coverage      ?   97.57%           
=====================================
  Files         ?       55           
  Lines         ?     2516           
  Branches      ?        0           
=====================================
  Hits          ?     2455           
  Misses        ?       61           
  Partials      ?        0
Flag Coverage Δ
unittests 97.57% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
woile
woile reviewed Aug 16, 2024
View reviewed changes

@woile woile left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lee-W thoughts on this? LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Lee-W

Lee-W commented Aug 16, 2024

Copy link
Copy Markdown
Member

Looks good to me. but we probably won't want to bump a major version for it. so I would suggest we remove the ! in all the commits
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AdrianDC

AdrianDC commented Aug 16, 2024

Copy link
Copy Markdown
Contributor Author

Thanks for the feedback.

IMO this should be a ! change, as any user having args: [] as I used to will have local and CI breakages.

Could go along other fixes such as #1206 and #1207

Example local usage until released: https://gitlab.com/RadianDevCore/tools/gcil/-/blob/53e6cb534ff77704ac9b9dc51d755b9965556910/.pre-commit-config.yaml#L54
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Lee-W

Lee-W commented Aug 16, 2024

Copy link
Copy Markdown
Member

If that's the case, we'll need to wait for our next release. @woile we probably can create a v4 branch already?
woile reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Lee-W Lee-W added the v4 label Aug 17, 2024
@Lee-W Lee-W mentioned this pull request Aug 17, 2024
commitizen v4 #1073
Closed
3 tasks
@AdrianDC AdrianDC mentioned this pull request Aug 19, 2024
cz check range sometimes failed in GitLab CI #593
Closed
@Lee-W
Lee-W changed the base branch from master to v4 August 22, 2024 02:33
dependabot Bot and others added 3 commits August 23, 2024 10:18
@dependabot @Lee-W
build(deps-dev): bump ruff from 0.6.1 to 0.6.2
9f085a1 
Bumps [ruff](https://github.com/astral-sh/ruff) from 0.6.1 to 0.6.2.
- [Release notes](https://github.com/astral-sh/ruff/releases)
- [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md)
- [Commits](astral-sh/ruff@0.6.1...0.6.2)

---
updated-dependencies:
- dependency-name: ruff
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@AdrianDC
fix(pre-commit-hooks)!: move 'check' to 'args' for global options
2a129d8 
Details: 'args: [...]' is not able to access '-nr NO_RAISE' global
         arguments for example from a arguments configuration
---

Signed-off-by: Adrian DC <[email protected]>
@AdrianDC
fix(pre-commit-hooks)!: allow empty ranges in 'commitizen-branch'
5e4cbd6 
Details: Pushing the same history from 'develop' to 'staging' for
         example fails because range 'origin/HEAD..HEAD' is empty
> No commit found with range: 'origin/HEAD..HEAD'
---

Signed-off-by: Adrian DC <[email protected]>
@AdrianDC
AdrianDC force-pushed the hooks-branch-empty-range branch from 5885a04 to 5e4cbd6 Compare August 25, 2024 00:52
Lee-W
Lee-W approved these changes Nov 10, 2024
View reviewed changes
@Lee-W

Lee-W commented Nov 10, 2024

Copy link
Copy Markdown
Member

Just change the base to v4. and let's merge it 🚀
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Lee-W
Lee-W merged commit 39cdcfa into commitizen-tools:v4 Nov 10, 2024
@AdrianDC
AdrianDC deleted the hooks-branch-empty-range branch November 16, 2024 11:51
@AdrianDC AdrianDC mentioned this pull request Nov 8, 2026
fix(pre-commit-hooks): allow empty ranges in 'commitizen-branch' #2121
Open
6 of 12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@woile woile woile left review comments
@Lee-W Lee-W Lee-W approved these changes
@noirbizarre noirbizarre Awaiting requested review from noirbizarre

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

pr-status: wait-for-review v4

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@AdrianDC @Lee-W @woile
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.