GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Another fix for #358: async thr wait in basic_client_facade dtor by leecoder · Pull Request #405 · cpp-netlib/cpp-netlib

Conversation

@leecoder

@leecoder leecoder commented Jun 23, 2014

Copy link
Copy Markdown

Sometimes, it has crashed in my tc after #402.

*** glibc detected *** ./TestHttp: double free or corruption (out): 0x00007fe760001f70 ***

It's maybe a race condition.
So, I've rewritten by async thr wait in basic_client_facade dtor.
It perfectly works as following http_temp_client_get_test.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@leecoder
Async thr wait in basic_client_facade dtor
2be7e30
deanberris
deanberris reviewed Jun 24, 2014
View reviewed changes
Comment thread boost/network/protocol/http/client/facade.hpp Outdated

@deanberris deanberris Jun 24, 2014

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this need to be virtual?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@leecoder leecoder Jun 25, 2014

Copy link
Copy Markdown
Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, it's not needed in this case. It's just my habit. I'll remove it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@leecoder
Update facade.hpp
c355924
@deanberris

deanberris commented Jun 25, 2014

Copy link
Copy Markdown
Member

LGTM -- thanks @leecoder, I'm merging now.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
deanberris added a commit that referenced this pull request Jun 25, 2014
@deanberris
Merge pull request #405 from leecoder/0.11-devel
770858b 
Another fix for #358: async thr wait in basic_client_facade dtor
@deanberris
deanberris merged commit 770858b into cpp-netlib:0.11-devel Jun 25, 2014
@leecoder leecoder mentioned this pull request Jun 25, 2014
program hanging in pthread_cond_wait() #386
Closed
leecoder pushed a commit to leecoder/cpp-netlib that referenced this pull request Apr 14, 2015
@deanberris
Merge pull request cpp-netlib#405 from leecoder/0.11-devel
f6715f0 
Another fix for cpp-netlib#358: async thr wait in basic_client_facade dtor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@leecoder @deanberris
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.