GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — ICC fixes by eile · Pull Request #737 · cpp-netlib/cpp-netlib

Conversation

@eile

@eile eile commented Mar 1, 2017

Copy link
Copy Markdown

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
deanberris
deanberris requested changes Mar 1, 2017
View reviewed changes

@deanberris deanberris left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes seem unnecessary and unrelated.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread boost/network/protocol/http/client/facade.hpp
if (boost::empty(content_type_headers)) {
typedef typename char_<Tag>::type char_type;
static char_type content_type[] = "x-application/octet-stream";
static char_type* content_type = "x-application/octet-stream";

@deanberris deanberris Mar 1, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need to make this change?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@eile eile Mar 1, 2017

Copy link
Copy Markdown
Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the same as #738

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread boost/network/protocol/http/client/facade.hpp
if (boost::empty(content_type_headers)) {
typedef typename char_<Tag>::type char_type;
static char_type content_type[] = "x-application/octet-stream";
static char_type* content_type = "x-application/octet-stream";

@deanberris deanberris Mar 1, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@eile

eile commented Mar 1, 2017

Copy link
Copy Markdown
Author

This is #734 and #738 for master
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dnachbaur

dnachbaur commented Mar 5, 2017

Copy link
Copy Markdown

#734 is already merged into master (was #729 on 0.13).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@eile Stefan Eilemann
ICC fixes (#4)
3c5456a
@eile
eile force-pushed the master branch from 3549553 to 3c5456a Compare March 6, 2017 10:53
@eile eile changed the title Expose OS-chosen address and port from async_server ICC fixes Mar 6, 2017
@eile

eile commented Mar 6, 2017

Copy link
Copy Markdown
Author

Corrected to only ICC fixes.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@anonimal

anonimal commented Aug 29, 2017

Copy link
Copy Markdown

@deanberris @glynos status?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@deanberris

deanberris commented Oct 17, 2017

Copy link
Copy Markdown
Member

LGTM

I'm not sure this is actually a valid change to make -- I don't understand why ICC isn't able to just initialise the character array with a literal, as that's valid C++. However, if this is something that's actively blocking adoption, then I suppose merging it is fine.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@deanberris
deanberris merged commit b17bc59 into cpp-netlib:master Oct 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deanberris deanberris deanberris requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@eile @dnachbaur @anonimal @deanberris
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.