GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — ICC fixes by eile · Pull Request #738 · cpp-netlib/cpp-netlib

Conversation

@eile

@eile eile commented Mar 1, 2017 •
edited by deanberris
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

const-qualify function-local static constant arrays.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@eile
ICC fixes (#4)
d2f806f
deanberris
deanberris requested changes Mar 1, 2017
View reviewed changes
Comment thread boost/network/protocol/http/client/facade.hpp Outdated
if (boost::empty(content_type_headers)) {
typedef typename char_<Tag>::type char_type;
static char_type content_type[] = "x-application/octet-stream";
static char_type* content_type = "x-application/octet-stream";

@deanberris deanberris Mar 1, 2017

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose a better change here would be:

static char_type const content_type[] = "...";

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Stefan Eilemann Stefan Eilemann
ICC fix, as suggested upstream
831be70
@eile

eile commented Mar 1, 2017

Copy link
Copy Markdown
Author

Updated.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@deanberris

deanberris commented Mar 1, 2017

Copy link
Copy Markdown
Member

LGTM -- thanks @eile!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@deanberris
deanberris merged commit f17d305 into cpp-netlib:0.13-release Mar 1, 2017
@eile eile mentioned this pull request Mar 1, 2017
ICC fixes #737
Merged
@dnachbaur

dnachbaur commented Aug 18, 2017

Copy link
Copy Markdown

@deanberris your requested change actually does not work, at least with icc 17:

boost/network/protocol/http/client/facade.hpp(134): error: a value of type "const char [27]" cannot be used to initialize an entity of type "const char_type []"
          static char_type const content_type[] = "x-application/octet-stream";

I suggest to keep the initial code change by @eile:

static char_type* const content_type = "x-application/octet-stream";

I just verified that this compiles.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@deanberris

deanberris commented Aug 18, 2017

Copy link
Copy Markdown
Member

@tribal-tec -- that's interesting, why isn't this an ICC bug?

If you send me a pull request I'd be happy to review and merge it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deanberris deanberris deanberris requested changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@eile @deanberris @dnachbaur
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.