GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix compilation errors with VS2015 by umennel · Pull Request #762 · cpp-netlib/cpp-netlib

Conversation

@umennel

@umennel umennel commented Jun 13, 2017

Copy link
Copy Markdown

I had to make some changes to get this compiling with VS2015 again. It complained about conversion from const char* to std::array<...>::const_iterator. So I had to add explicit casts. The downside is that the code became a bit ugly now and more difficult to read. Maybe using typedefs for the array and array iterator types would help?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@umennel umennel mentioned this pull request Aug 13, 2017
Compilation errors with VS2015 on master #773
Closed
@anonimal

anonimal commented Aug 29, 2017

Copy link
Copy Markdown

@deanberris @glynos ?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@umennel Uche Mennel
Fix compilation errors with VS2015
ddb372d
@umennel
umennel force-pushed the vs2015_compiler_fixes branch from 04c0afd to ddb372d Compare September 15, 2017 19:35
@deanberris

deanberris commented Oct 17, 2017

Copy link
Copy Markdown
Member

LGTM -- in the future typedefs/aliases would make this better to read. For now it's localised and makes sense anyway.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@deanberris
deanberris merged commit 827867f into cpp-netlib:master Oct 17, 2017
umennel added a commit to umennel/cpp-netlib that referenced this pull request Mar 31, 2018
@umennel
Fix compilation errors with VS2015 (cpp-netlib#762)
7f8d398
umennel added a commit to umennel/cpp-netlib that referenced this pull request Mar 31, 2018
@umennel
Fix compilation errors with VS2015 (cpp-netlib#762)
e14fe25
deanberris pushed a commit that referenced this pull request Apr 3, 2018
@umennel @deanberris
Fix compilation errors with VS2015 (#762)
64319f9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@umennel @anonimal @deanberris
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.