GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Enable remove_chunk_markers by default. Fix a bug and add a comment. by igorpeshansky · Pull Request #830 · cpp-netlib/cpp-netlib

Conversation

@igorpeshansky

@igorpeshansky igorpeshansky commented Mar 15, 2018

Copy link
Copy Markdown

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@igorpeshansky
Enable remove_chunk_markers by default. Fix a bug and add a comment.
501d87d
@igorpeshansky igorpeshansky mentioned this pull request Mar 15, 2018
Introduced new chunked transfer encoding parser to remove chunk markers #720
Merged
@igorpeshansky

igorpeshansky commented Mar 15, 2018

Copy link
Copy Markdown
Author

@deanberris PTAL.
@umennel FYI.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
deanberris
deanberris approved these changes Mar 15, 2018
View reviewed changes

@deanberris deanberris left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@deanberris
deanberris merged commit 540ed76 into cpp-netlib:master Mar 15, 2018
@deanberris

deanberris commented Mar 15, 2018

Copy link
Copy Markdown
Member

Thanks, @igorpeshansky -- would it make sense if you merge these into 0.13-release as well? It may not be a straight-forward merge.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@igorpeshansky

igorpeshansky commented Mar 15, 2018

Copy link
Copy Markdown
Author

@deanberris Did you mean both #720 and #830?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@deanberris

deanberris commented Mar 22, 2018

Copy link
Copy Markdown
Member

@igorpeshansky Yes, both those would be good to see in 0.13-release.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@umennel

umennel commented Mar 31, 2018

Copy link
Copy Markdown

Cherry-picked commits from both PRs with #833
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deanberris deanberris deanberris approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@igorpeshansky @deanberris @umennel
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.