GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix client_get_streaming_test by yhager · Pull Request #840 · cpp-netlib/cpp-netlib

Conversation

@yhager

@yhager yhager commented May 15, 2018

Copy link
Copy Markdown

fixes #836

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@yhager
fix client_get_streaming_test
16c1619
deanberris
deanberris requested changes May 16, 2018
View reviewed changes
Comment thread libs/network/test/http/client_get_streaming_test.cpp

TYPED_TEST(HTTPClientTest, GetStreamingTest) {
typename TypeParam::request request("http://www.boost.org");
typename TypeParam::request request("https://www.boost.org");

@deanberris deanberris May 16, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @yhager -- we probably want to only build this particular test now if we've enabled HTTPS support. Can you try making this whole test conditional on whether the BOOST_NETWORK_ENABLE_HTTPS macro is defined?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@deanberris deanberris May 17, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be much simpler to do:

#if BOOST_NETWORK_ENABLE_HTTPS
TYPED_TEST(HTTPClientTest, GetStreamingTest) {
...
}
#endif

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@yhager yhager May 17, 2018

Copy link
Copy Markdown
Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problem. Pushed the change you requested. Sorry for misunderstanding what you meant.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@deanberris deanberris May 17, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@yhager
perform client_get_streaming_test only if SSL is enabled
adb024a
deanberris
deanberris requested changes May 17, 2018
View reviewed changes
Comment thread libs/network/test/http/CMakeLists.txt Outdated
client_get_ready_test)
if (OPENSSL_FOUND)
list(APPEND TESTS client_get_streaming_test)
endif()

@deanberris deanberris May 17, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is what I meant.

The client_get_streaming_test could have just skipped building the GetStreamingTest by checking whether the BOOST_NETWORK_ENABLE_HTTPS as a preprocessor macro. Please revert this part of the PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread libs/network/test/http/client_get_streaming_test.cpp

TYPED_TEST(HTTPClientTest, GetStreamingTest) {
typename TypeParam::request request("http://www.boost.org");
typename TypeParam::request request("https://www.boost.org");

@deanberris deanberris May 17, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be much simpler to do:

#if BOOST_NETWORK_ENABLE_HTTPS
TYPED_TEST(HTTPClientTest, GetStreamingTest) {
...
}
#endif

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
yhager added 2 commits May 17, 2018 08:49
@yhager
test for BOOST_NETWORK_ENABLE_HTTPS for https streaming test
c1702e3
@yhager
Merge remote-tracking branch 'origin/0.13-release' into yhager/836
a9904fa
deanberris
deanberris approved these changes May 17, 2018
View reviewed changes

@deanberris deanberris left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks @yhager!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread libs/network/test/http/client_get_streaming_test.cpp

TYPED_TEST(HTTPClientTest, GetStreamingTest) {
typename TypeParam::request request("http://www.boost.org");
typename TypeParam::request request("https://www.boost.org");

@deanberris deanberris May 17, 2018

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@deanberris
deanberris merged commit 90847f3 into cpp-netlib:0.13-release May 17, 2018
deanberris pushed a commit that referenced this pull request Jun 14, 2018
@yhager @deanberris
fix client_get_streaming_test (#840)
ed6ff63 
* fix client_get_streaming_test

* perform client_get_streaming_test only if SSL is enabled

* test for BOOST_NETWORK_ENABLE_HTTPS for https streaming test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deanberris deanberris deanberris approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@yhager @deanberris
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.