GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix for boost 1.70 (get_io_service() was deprecated and was removed) by enricodetoma · Pull Request #878 · cpp-netlib/cpp-netlib

Conversation

@enricodetoma

@enricodetoma enricodetoma commented Aug 6, 2019

Copy link
Copy Markdown

get_io_service() was removed in Boost 1.70.

I made a pull request using the alternative get_executor().context()

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
enricodetoma added 3 commits August 6, 2019 08:00
@enricodetoma
Fix for boost 1.70 (get_io_service() was deprecated and was removed)
dfaa858
@enricodetoma
Fix for boost 1.70 (get_io_service() was deprecated and was removed)
cf11364
@enricodetoma
Fix for boost 1.70 (get_io_service() was deprecated and was removed)
5351fc6
@enricodetoma

enricodetoma commented Aug 8, 2019

Copy link
Copy Markdown
Author

I forgot to keep compatibility with older ASIO versions. Now the pull request should be ok.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@enricodetoma enricodetoma mentioned this pull request Aug 8, 2019
Does not compile with Boost 1.70 and newer #875
Open
deanberris
deanberris requested changes Aug 8, 2019
View reviewed changes

@deanberris deanberris left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @enricodetoma!

Please find comments below.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread boost/network/protocol/http/client/connection/async_base.hpp Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread boost/network/protocol/http/client/connection/async_base.hpp Resolved

Uh oh!

There was an error while loading. Please reload this page.
@enricodetoma
Fix for boost 1.70 (get_io_service() was deprecated and was removed)
9aaa546
deanberris
deanberris requested changes Aug 9, 2019
View reviewed changes

@deanberris deanberris left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple more requests and I think we're almost there... :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread boost/network/compat.hpp Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread boost/network/compat.hpp Resolved

Uh oh!

There was an error while loading. Please reload this page.
@enricodetoma
Fix for boost 1.70 (get_io_service() was deprecated and was removed)
77adf2d
deanberris
deanberris requested changes Aug 9, 2019
View reviewed changes
Comment thread boost/network/protocol/http/client/connection/connection_delegate_factory.hpp Resolved

Uh oh!

There was an error while loading. Please reload this page.
@enricodetoma
Fix for boost 1.70 (get_io_service() was deprecated and was removed)
227f552
deanberris
deanberris approved these changes Aug 12, 2019
View reviewed changes

@deanberris deanberris left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @enricodetoma!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@deanberris
deanberris merged commit 2bef8be into cpp-netlib:0.13-release Aug 12, 2019
yogev-lb added a commit to LightBitsLabs/osmosis that referenced this pull request Mar 23, 2023
@yogev-lb
upgrade cpp-netlib to work with boost>1.70
f65d8e2 
using the following patch:

cpp-netlib/cpp-netlib#878

to update support for new boost.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deanberris deanberris deanberris approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@enricodetoma @deanberris
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.