GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Added custom timeout to ci by kitsiosk · Pull Request #7641 · cppcheck-opensource/cppcheck

Conversation

@kitsiosk

@kitsiosk kitsiosk commented Jul 2, 2025

Copy link
Copy Markdown
Contributor

Change Summary

Added custom timeout for build_mingw job of the CI-mingw workflow based on historical data.

More details

Over the last 7456 successful runs, the build_mingw job has a maximum runtime of 13 minutes (mean=4, std=2).

However, there are failed runs that fail after reaching the threshold of 6 hours that GitHub imposes. In other words, these jobs seem to get stuck, possibly for external or random reasons.

One such example is this job run, that failed after 6 hours. More stuck jobs have been observed over the last six months, the first one on 2025-01-01 and the last one one on 2025-04-09, while more recent occurences are also possible because our dataset has a cutoff date around late May. With the proposed changes, a total of 45 hours would have been saved over the last six months retrospectively, clearing the queue for other workflows and speeding up the CI of the project, while also saving resources in general.

The idea is to set a timeout to stop jobs that run much longer than their historical maximum, because such jobs are probably stuck and will simply fail with a timeout at 6 hours.

Our PR proposes to set the timeout to max + 3*std = 19 minutes where max and std (standard deviation) are derived from the history of 7456 successful runs. This will provide sufficient margin if the workflow gets naturally slower in the future, but if you would prefer lower/higher threshold we would be happy to do it.

Context

Hi,

We are a team of researchers from University of Zurich and we are currently working on energy optimizations in GitHub Actions workflows.

Thanks for your time on this.

Feel free to let us know (here or in the email below) if you have any questions, and thanks for putting in the time to read this.

Best regards,
Konstantinos Kitsios
[email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kitsiosk
Added custom timeout to ci
4883d14
@kitsiosk kitsiosk mentioned this pull request Jul 2, 2025
fixed #12325 - cancel workflows if a newer commit is pushed on the same branch #7636
Open
@kitsiosk
Typo fix
3c460fc
@danmar

danmar commented Jul 3, 2025

Copy link
Copy Markdown
Collaborator

it sounds good to me.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kitsiosk

kitsiosk commented Jul 3, 2025

Copy link
Copy Markdown
Contributor Author

The CI failures seem unrelated to the changes, they are in a different yaml file that the one I changed. Is this something intermittent?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@danmar

danmar commented Jul 4, 2025

Copy link
Copy Markdown
Collaborator

Is this something intermittent?

I guess so I saw similar intermittent problems before.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@chrchr-github

chrchr-github commented Jul 5, 2025

Copy link
Copy Markdown
Collaborator

Seems related to #7433 somehow
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kitsiosk

kitsiosk commented Jul 7, 2025

Copy link
Copy Markdown
Contributor Author

Seems related to #7433 somehow

Indeed, it's the same library but not the same error.

Should I try commenting out the changes to see if it still fails?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@chrchr-github

chrchr-github commented Jul 7, 2025

Copy link
Copy Markdown
Collaborator

Should I try commenting out the changes to see if it still fails?

That might be helpful as a sanity check.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@danmar

danmar commented Jul 9, 2025

Copy link
Copy Markdown
Collaborator

Indeed, it's the same library but not the same error.

I saw another PR with the same QPair problem a week ago and that CI was solved when I rerun the CI.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@chrchr-github

chrchr-github commented Jul 9, 2025

Copy link
Copy Markdown
Collaborator

Indeed, it's the same library but not the same error.

I saw another PR with the same QPair problem a week ago and that CI was solved when I rerun the CI.

We're up to 8 reruns now, and the failure persists... Elsewhere the CI runs fine.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kitsiosk
Commented out changes as a sanity check for the CI failures
96f412d
@kitsiosk

kitsiosk commented Jul 9, 2025

Copy link
Copy Markdown
Contributor Author

Should I try commenting out the changes to see if it still fails?

That might be helpful as a sanity check.

Hi @chrchr-github, just did this, let's see what happens. I think you need to approve the workflows to run.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@danmar

danmar commented Jul 10, 2025

Copy link
Copy Markdown
Collaborator

Indeed, it's the same library but not the same error.

I saw another PR with the same QPair problem a week ago and that CI was solved when I rerun the CI.

We're up to 8 reruns now, and the failure persists... Elsewhere the CI runs fine.

yes I am starting to loose faith too..
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kitsiosk
Added timeout again to see if build passes
2c11ca2 
Signed-off-by: Konstantinos <[email protected]>
@kitsiosk

kitsiosk commented Jul 10, 2025

Copy link
Copy Markdown
Contributor Author

Indeed, it's the same library but not the same error.

I saw another PR with the same QPair problem a week ago and that CI was solved when I rerun the CI.

We're up to 8 reruns now, and the failure persists... Elsewhere the CI runs fine.

yes I am starting to loose faith too..

Let's see after commenting and uncommenting again if something changed. If not, I will convert this into a draft and perform a deep dig to see what's happening because it would be very weird.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@chrchr-github
chrchr-github merged commit 16406b2 into cppcheck-opensource:main Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@kitsiosk @danmar @chrchr-github
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.