GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fixed #13853 - updated Qt to 6.9.0 by firewave · Pull Request #7433 · cppcheck-opensource/cppcheck

Conversation

@firewave

@firewave firewave commented Apr 5, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@firewave

firewave commented Apr 5, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator Author
D:\a\cppcheck\Qt\6.9.0\msvc2022_64\include\QtCharts\qxyseries.h(132,10): error C2143: syntax error: missing ';' before '<' [D:\a\cppcheck\cppcheck\build\gui\cppcheck-gui.vcxproj]
  (compiling source file '../../gui/statsdialog.cpp')

This is caused by the header using the deprecated QPair which we disabled.

Update: I filed https://bugreports.qt.io/browse/QTBUG-135637 about it.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@firewave
firewave marked this pull request as draft April 5, 2025 09:29
@firewave
firewave force-pushed the qt-69 branch from b962124 to 3b4a2be Compare April 5, 2025 09:37
@firewave

firewave commented Apr 5, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator Author
/home/runner/work/cppcheck/cppcheck/cmake.output/gui/test/resultstree/__/__/moc_projectfile.cpp:40:5: error: 'QtMocHelpers::StringRefStorage' may not intend to support class template argument deduction [clang-diagnostic-ctad-maybe-unsupported]
   40 |     QtMocHelpers::StringRefStorage qt_stringData {
      |     ^
/home/runner/work/cppcheck/Qt/6.9.0/gcc_64/include/QtCore/qtmochelpers.h:57:39: note: add a deduction guide to suppress this warning
   57 | template <typename... Strings> struct StringRefStorage
      |                                       ^
/home/runner/work/cppcheck/cppcheck/cmake.output/gui/test/resultstree/__/__/moc_projectfile.cpp:44:5: error: 'QtMocHelpers::UintData' may not intend to support class template argument deduction [clang-diagnostic-ctad-maybe-unsupported]
   44 |     QtMocHelpers::UintData qt_methods {
      |     ^
/home/runner/work/cppcheck/Qt/6.9.0/gcc_64/include/QtCore/qtmochelpers.h:211:37: note: add a deduction guide to suppress this warning
  211 | template <typename... Block> struct UintData
      |                                     ^

I filed https://bugreports.qt.io/browse/QTBUG-135638 about this.

Update: This causes a build failure with Visual Studio 2019.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@firewave
firewave force-pushed the qt-69 branch from 3b4a2be to 485c793 Compare April 5, 2025 09:55
@firewave

firewave commented Apr 7, 2025

Copy link
Copy Markdown
Collaborator Author

Qt 6.8.x already removed support for VS2019: https://doc.qt.io/qt-6.8/windows.html. So we should/need to remove that combination from the CI.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@firewave

This comment was marked as resolved.

Sign in to view
@firewave

This comment was marked as resolved.

Sign in to view
@firewave
firewave force-pushed the qt-69 branch from 485c793 to 9d4a571 Compare May 15, 2025 13:02
@firewave firewave changed the title updated Qt to 6.9.0 fixed #13853 - updated Qt to 6.9.0 May 15, 2025
@firewave
firewave force-pushed the qt-69 branch from 6d952aa to 4fee7c1 Compare May 16, 2025 19:44
@firewave
firewave marked this pull request as ready for review May 16, 2025 19:45
@firewave
firewave force-pushed the qt-69 branch from 4fee7c1 to 62b7bea Compare May 16, 2025 20:05
@firewave

firewave commented May 16, 2025

Copy link
Copy Markdown
Collaborator Author

Successful installer build with changes applied: https://github.com/danmar/cppcheck/actions/runs/15045760579.

I gave it a short spin and the GUI seems to work fine.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@firewave
fixed #13853 - updated Qt to 6.9.0
84a68fc
@firewave
firewave force-pushed the qt-69 branch from 62b7bea to 84a68fc Compare May 17, 2025 07:13
danmar
danmar approved these changes May 17, 2025
View reviewed changes
@firewave
firewave merged commit 5147b19 into cppcheck-opensource:main May 17, 2025
@firewave
firewave deleted the qt-69 branch May 17, 2025 12:35
danmar pushed a commit to cppchecksolutions/cppcheck that referenced this pull request May 20, 2025
@firewave @danmar
fixed #13853 - updated Qt to 6.9.0 (cppcheck-opensource#7433)
5da1683
@chrchr-github chrchr-github mentioned this pull request Jul 5, 2025
Added custom timeout to ci #7641
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danmar danmar danmar approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@firewave @danmar
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.