GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — fixed #14738 gui recheck file not working properly when importing compile_commands.json by wjakobsson · Pull Request #8625 · cppcheck-opensource/cppcheck

fixed #14738 gui recheck file not working properly when importing compile_commands.json #8625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

wjakobsson merged 3 commits into cppcheck-opensource:main from wjakobsson:fix-guiselectfiles

Jun 4, 2026

Uh oh!

There was an error while loading. Please reload this page.

Merged

fixed #14738 gui recheck file not working properly when importing compile_commands.json #8625

Show file tree

Hide file tree

Changes from all commits

Commits

Show all changes

3 commits

Select commit Hold shift + click to select a range

File filter

Filter by extension .cpp (1) .h (1) All 2 file types selected

Viewed files

Clear filters

Conversations

Failed to load comments.

Uh oh!

There was an error while loading. Please reload this page.

Jump to

Jump to file

Failed to load files.

Uh oh!

There was an error while loading. Please reload this page.

Diff view

Unified

Split

Hide whitespace

Diff view

Unified

Split

Hide whitespace

There are no files selected for viewing

11 changes: 9 additions & 2 deletions 11 gui/mainwindow.cpp

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -559,13 +559,20 @@ void MainWindow::saveSettings() const
		mUI->mResults->saveSettings(mSettings);
		}

		void MainWindow::doAnalyzeProject(ImportProject p, const bool checkLib, const bool checkConfig)
		void MainWindow::doAnalyzeProject(ImportProject p, const bool checkLib, const bool checkConfig, const QStringList& recheckFiles)
		{
		Settings checkSettings;
		auto supprs = std::make_shared<Suppressions>();
		if (!getCppcheckSettings(checkSettings, *supprs))
		return;

		// filter requested files
		if (!recheckFiles.isEmpty()) {
		p.fileSettings.remove_if([&](const FileSettings& fs) {
		return !recheckFiles.contains(QString::fromStdString(fs.filename()));
		});
		}

		clearResults();

		mIsLogfileLoaded = false;
Expand Down Expand Up		@@ -1958,7 +1965,7 @@ void MainWindow::analyzeProject(const ProjectFile *projectFile, const QStringLis
		msg.exec();
		return;
		}
		doAnalyzeProject(p, checkLib, checkConfig); // TODO: avoid copy
		doAnalyzeProject(p, checkLib, checkConfig, recheckFiles); // TODO: avoid copy
		return;
		}

Expand Down

2 changes: 1 addition & 1 deletion 2 gui/mainwindow.h

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -309,7 +309,7 @@ private slots:
		* @param checkLib Flag to indicate if library should be checked
		* @param checkConfig Flag to indicate if the configuration should be checked.
		*/
		void doAnalyzeProject(ImportProject p, bool checkLib = false, bool checkConfig = false);
		void doAnalyzeProject(ImportProject p, bool checkLib = false, bool checkConfig = false, const QStringList& recheckFiles = QStringList());

		/**
		* @brief Analyze all files specified in parameter files
Expand Down

Oops, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.