GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Revert "fix: use both absolute and relative header paths in header matching (#362)" by danmar · Pull Request #415 · cppcheck-opensource/simplecpp

Conversation

@danmar

@danmar danmar commented Feb 12, 2025

Copy link
Copy Markdown
Collaborator

This reverts commit c4b6e37.

There was build errors when simplecpp was used in cppcheck:

       "D:\a\cppcheck\cppcheck\cppcheck.sln" (default target) (1) ->
       "D:\a\cppcheck\cppcheck\cli\cli.vcxproj.metaproj" (default target) (2) ->
       "D:\a\cppcheck\cppcheck\lib\cppcheck.vcxproj" (default target) (4) ->
       (ClCompile target) -> 
         D:\a\cppcheck\cppcheck\externals\simplecpp\simplecpp.cpp(152,13): error C2375: 'startsWith': redefinition; different linkage [D:\a\cppcheck\cppcheck\lib\cppcheck.vcxproj]
         D:\a\cppcheck\cppcheck\externals\simplecpp\simplecpp.cpp(2726,17): error C2440: 'return': cannot convert from 'TCHAR [260]' to 'std::basic_string<char,std::char_traits<char>,std::allocator<char>>' [D:\a\cppcheck\cppcheck\lib\cppcheck.vcxproj]
         D:\a\cppcheck\cppcheck\externals\simplecpp\simplecpp.cpp(2753,8): error C2264: 'startsWith': error in function definition or declaration; function not called [D:\a\cppcheck\cppcheck\lib\cppcheck.vcxproj]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@danmar
Revert "fix: use both absolute and relative header paths in header ma…
fe2103c 
…tching (#362)"

This reverts commit c4b6e37.
@danmar

danmar commented Feb 12, 2025

Copy link
Copy Markdown
Collaborator Author

@Tal500 This reverts your fix. Please feel free to revert this and look at the error messages. Ideally we should be able to reproduce them here in the simplecpp repo also.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@danmar
danmar merged commit 9ce981c into master Feb 12, 2025
@danmar
danmar deleted the revert branch February 12, 2025 14:37
@firewave

firewave commented Feb 13, 2025

Copy link
Copy Markdown
Collaborator

We should be able to detect this earlier - I filed #417 about that.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Tal500 pushed a commit to Tal500/simplecpp that referenced this pull request Feb 16, 2025
Tal Hadad
Revert "Revert "fix: use both absolute and relative header paths in h…
c912799 
…eader matching (cppcheck-opensource#362)" (cppcheck-opensource#415)"

This reverts commit 9ce981c.
@Tal500 Tal500 mentioned this pull request Feb 16, 2025
Fix relative paths, again #418
Merged
@Tal500

Tal500 commented Feb 16, 2025

Copy link
Copy Markdown
Contributor

@Tal500 This reverts your fix. Please feel free to revert this and look at the error messages. Ideally we should be able to reproduce them here in the simplecpp repo also.

I think I fixed these issues by #418.
Please tell me if there are any Windows build issue that are left (my Windows resources are limited, but I tried my best).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@danmar @firewave @Tal500
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.