GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix(whitespace/indent_namespace): Three false positives by aaronliu0130 · Pull Request #376 · cpplint/cpplint

Conversation

@aaronliu0130

@aaronliu0130 aaronliu0130 commented Apr 17, 2025

Copy link
Copy Markdown
Member

Should fix #372

fix(whitespace/indent_namespace): Specifier & multiline false positives for constructors

  • Fix false positive for when a function specifier (e.g. inline, protected) is provided
  • Fix false positive for when constructor ends on the same line a MemInitList does, but on a different line from said list's start
  • Fix ownership assignment of open parentheses
  • Use search instead of match for some cases
  • Fix typo & misc refactoring

fix(whitespace/indent_namespace): Curly braces in MemInitList

  • Fixes : a({0}), b{"c", d} etc. F/Ps
  • Consumes and updates state of MemInitList so we get to the curly braces before _ConsumeEnd() does
  • Splits ending token searches/checks into _ConsumeEnd()
  • Requires starting index to initialize _WrapInfos
  • Renames _WrappedInfo to _WrapInfo since Wrapped is not a noun

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@aaronliu0130
aaronliu0130 requested a review from cclauss April 18, 2025 13:35
@aaronliu0130
aaronliu0130 temporarily deployed to testpypi April 23, 2025 21:48 — with GitHub Actions Inactive
@aaronliu0130
aaronliu0130 requested a review from jayvdb May 18, 2025 22:41
@aaronliu0130 aaronliu0130 mentioned this pull request Oct 1, 2025
[pre-commit.ci] pre-commit autoupdate and Python 3.10 to 3.14 #397
Merged
This was referenced Oct 27, 2025
Several false positives for whitespace/indent_namespace #401
Open
Looking for more maintainers #402
Open
[NamespaceIndentation] constructor initializer list with {} should be… #404
Closed
@aaronliu0130 aaronliu0130 mentioned this pull request Nov 27, 2025
fix(IWYU): force std:: or <> for max, min, copy #411
Merged
cclauss
cclauss requested changes Nov 28, 2025
View reviewed changes
Comment thread cpplint.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread cpplint.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

aaronliu0130 added 3 commits November 28, 2025 10:48
@aaronliu0130
fix(whitespace/indent_namespace): Specifier & multiline false positiv…
de770c5
…es for constructors

Fix false positive for when a function specifier (e.g. `inline`, `protected`) is provided
Fix false positive for when constructor ends on the same line a MemInitList does, but on a different line from said list's start
Fix ownership assignment of open parentheses
Use search instead of match for some cases
Fix typo & misc refactoring
@aaronliu0130
fix(whitespace/indent_namespace): Curly braces in MemInitList
21f2d05
Fixes `: a({0}), b{"c", d}` etc. F/Ps
Consumes and updates state of MemInitList so we get to the curly braces before _ConsumeEnd() does
Splits ending token searches/checks into `_ConsumeEnd()`
Requires starting index to initialize `_WrapInfo`s
Renames _WrappedInfo to _WrapInfo since Wrapped is not a noun
@aaronliu0130
fix(whitespace/indent_namespace): Brace parsing direction and unretur…
032ab5f
…ned consumption

Fix the direction in which we find braces
Fix bug where consumption doesn't happen due to return None without returning the consumed line
Refactored consumption functions to have the loop themselves
Change tests to account for that
@aaronliu0130
aaronliu0130 force-pushed the falsepositive branch from f0168fd to 032ab5f Compare November 28, 2025 15:49
@aaronliu0130
aaronliu0130 temporarily deployed to testpypi November 28, 2025 15:49 — with GitHub Actions Inactive
cclauss
cclauss approved these changes Nov 28, 2025
View reviewed changes
@aaronliu0130
Merge branch 'develop' into falsepositive
82e44a4
@aaronliu0130
aaronliu0130 temporarily deployed to testpypi November 28, 2025 17:40 — with GitHub Actions Inactive
@aaronliu0130
aaronliu0130 merged commit 45102d1 into develop Nov 28, 2025
11 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@aaronliu0130
aaronliu0130 deleted the falsepositive branch April 18, 2026 17:49
@janmarsino98 janmarsino98 mentioned this pull request Jul 16, 2026
fix: handle multiline function templates in namespaces #447
Open

This branch was previously deployed

1 inactive deployment
testpypi — 82e44a40 Deployed Nov 28, 2025 by aaronliu0130 via Publish Python 🐍 distribution 📦 to TestPyPI #124
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cclauss cclauss cclauss approved these changes
@jayvdb jayvdb Awaiting requested review from jayvdb

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

False positive for whitespace/indent_namespace with member initializer lists

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@aaronliu0130 @cclauss
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.