GeezerVisonThe World Wide Web, restored to 800 pixels of glory. |
| Home|About|Gaming cabinet|Archives|How it works|Starter sites |
GeezerVison is showing github.com — fix(whitespace/indent_namespace): Three false positives by aaronliu0130 · Pull Request #376 · cpplint/cpplint Conversation
Member
Should fix #372 fix(whitespace/indent_namespace): Specifier & multiline false positives for constructors
fix(whitespace/indent_namespace): Curly braces in MemInitList
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
This was referenced
cclauss
requested changes
Uh oh!
There was an error while loading. Please reload this page. Uh oh!
There was an error while loading. Please reload this page. …es for constructors Fix false positive for when a function specifier (e.g. `inline`, `protected`) is provided Fix false positive for when constructor ends on the same line a MemInitList does, but on a different line from said list's start Fix ownership assignment of open parentheses Use search instead of match for some cases Fix typo & misc refactoring Fixes `: a({0}), b{"c", d}` etc. F/Ps
Consumes and updates state of MemInitList so we get to the curly braces before _ConsumeEnd() does
Splits ending token searches/checks into `_ConsumeEnd()`
Requires starting index to initialize `_WrapInfo`s
Renames _WrappedInfo to _WrapInfo since Wrapped is not a noun
…ned consumption Fix the direction in which we find braces Fix bug where consumption doesn't happen due to return None without returning the consumed line Refactored consumption functions to have the loop themselves Change tests to account for that
aaronliu0130
force-pushed
the
falsepositive
branch
from
f0168fd to
032ab5f
Compare
aaronliu0130
temporarily deployed
to
testpypi
cclauss
approved these changes
aaronliu0130
temporarily deployed
to
testpypi
Uh oh!
There was an error while loading. Please reload this page. This branch was previously deployed1 inactive deployment
testpypi
—
82e44a40
Deployed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page. AssigneesNo one assignedLabels
None yet
ProjectsMilestoneNo milestoneDevelopmentSuccessfully merging this pull request may close these issues. False positive for whitespace/indent_namespace with member initializer listsUh oh!
There was an error while loading. Please reload this page. Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later. |
| You are visitor 01402520 — GeezerVison does not store the pages you look up. Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required. |