GeezerVison

cpplint.py (1)

4164-4170: 🚀 Performance & Scalability | 🔵 Trivial | ⚡ Quick win

Delay the multiline template check for better performance.

Currently, IsMultilineFunctionTemplateDeclaration runs for every line in the file. This results in unnecessary backward string scanning and regex evaluations for the vast majority of lines (e.g., inside function bodies or outside namespaces).

Moving this check inside the ShouldCheckNamespaceIndentation block ensures we only incur this cost for lines that are actually candidates for the namespace indentation warning.

⚡ Proposed refactor

-    if IsMultilineFunctionTemplateDeclaration(clean_lines, line):
-        return
-
     if ShouldCheckNamespaceIndentation(
         nesting_state, is_namespace_indent_item, clean_lines.elided, line
     ):
+        if IsMultilineFunctionTemplateDeclaration(clean_lines, line):
+            return
         CheckItemIndentationInNamespace(filename, clean_lines.elided, line, error)

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@cpplint.py` around lines 4164 - 4170, Move the
IsMultilineFunctionTemplateDeclaration check inside the
ShouldCheckNamespaceIndentation conditional, after confirming the line is a
namespace-indentation candidate and before calling
CheckItemIndentationInNamespace; remove the unconditional early return so the
expensive scan is skipped for unrelated lines.

cpplint_unittest.py (1)

326-357: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Add a test case for function template definitions.

The tests added here only cover function template declarations. To ensure that function template definitions (which include a { block) are also correctly exempted from false positive warnings and don't regress in the future, consider adding a test case for them. This will also verify the bug fix proposed in cpplint.py.

🧪 Proposed test addition

         ]
         assert self.GetNamespaceResults(lines) == ""
 
+        lines = [
+            "namespace Test {",
+            "template <typename Type1,",
+            "          typename Type2>",
+            "void TestFunc(const Type1 &var1, Type2 &var2) {",
+            "}",
+            "}  // namespace Test",
+        ]
+        assert self.GetNamespaceResults(lines) == ""
+
     def testNamespaceIndentationIndentedMultilineFunctionTemplateDeclaration(self):

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@cpplint_unittest.py` around lines 326 - 357, Add coverage in the namespace
indentation tests for multiline function template definitions, including a body
block with `{`, and verify correctly aligned definitions produce no warnings
while indented definitions report the expected namespace-indentation violations.
Extend the existing test methods near
testNamespaceIndentationMultilineFunctionTemplateDeclaration, reusing
GetNamespaceResults and the established declaration expectations.

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes