GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fix dco issue by moderakh · Pull Request #42 · databricks/databricks-sql-python

Conversation

@moderakh

@moderakh moderakh commented Aug 25, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

Signed-off-by: Moe Derakhshani [email protected]

my OAuth PR is blocked due to dco validation (following error):
Screen Shot 2022-08-25 at 12 05 40 PM

We should try to avoid running dco for internal databricks employees:
I am trying to relax the validation based on this guideline:
https://github.com/dcoapp/app/blob/main/README.md#skipping-sign-off-for-organization-members

and here:
https://stackoverflow.com/questions/62969381/is-it-in-line-with-the-dco-that-a-github-sign-off-needs-and-publishes-full-name

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
moderakh added 2 commits August 25, 2022 12:03
@moderakh
fix dco issue
706db76 
Signed-off-by: Moe Derakhshani <[email protected]>
@moderakh
fix dco issue
b174d24 
Signed-off-by: Moe Derakhshani <[email protected]>
@moderakh
moderakh requested review from arikfr, susodapop and yunbodeng-db as code owners August 25, 2022 19:04
@moderakh
moderakh merged commit c39f877 into databricks:main Aug 25, 2022
@moderakh moderakh mentioned this pull request Aug 25, 2022
dco tunning #43
Merged
moderakh added a commit that referenced this pull request Aug 25, 2022
@moderakh
Merge pull request #43 from moderakh/dco-tunning
72d9ea0 
Signed-off-by: Moe Derakhshani <[email protected]>

this is undo of #42 till we figure out how to fix dco
saishreeeee pushed a commit that referenced this pull request Jun 4, 2025
@moderakh
Merge pull request #42 from moderakh/fix-dco-issue
06d9df8 
Signed-off-by: Moe Derakhshani <[email protected]>

my [OAuth PR](https://github.com/databricks/databricks-sql-python/runs/8005844758?check_suite_focus=true) is blocked due to dco validation (following error):
<img width="1202" alt="Screen Shot 2022-08-25 at 12 05 40 PM" src="https://user-images.githubusercontent.com/22279672/186747897-c9d57586-366f-41f9-aa66-609f2bf3911f.png">



We should try to avoid running dco for internal databricks employees:
I am trying to relax the validation based on this guideline:
https://github.com/dcoapp/app/blob/main/README.md#skipping-sign-off-for-organization-members

and here:
https://stackoverflow.com/questions/62969381/is-it-in-line-with-the-dco-that-a-github-sign-off-needs-and-publishes-full-name
saishreeeee pushed a commit that referenced this pull request Jun 4, 2025
@moderakh
Merge pull request #43 from moderakh/dco-tunning
285e516 
Signed-off-by: Moe Derakhshani <[email protected]>

this is undo of #42 till we figure out how to fix dco
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susodapop susodapop Awaiting requested review from susodapop
@arikfr arikfr Awaiting requested review from arikfr
@yunbodeng-db yunbodeng-db Awaiting requested review from yunbodeng-db

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@moderakh
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.