GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add optional telemetry support to the python connector by saishreeeee · Pull Request #628 · databricks/databricks-sql-python

Conversation

@saishreeeee

@saishreeeee saishreeeee commented Jul 7, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • Other

Description

Initial telemetry logs, failure logs, latency logs via telemetry

How is this tested?

  • Unit tests
  • E2E Tests
  • Manually
  • N/A

Related Tickets & Documents

Design doc
PECOBLR-585

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
dbaxa and others added 30 commits August 17, 2022 14:02
@dbaxa
[PECO-197] Support Python 3.10 (#31)
5fd729a 
* Test with multiple python versions.
* Update pyarrow to version 9.0.0 to address issue in relation to python 3.10 & a specific version of numpy being pulled in by pyarrow.

Closes #26 

Signed-off-by: David Black <[email protected]>
Jesse
Update changelog and bump to v2.0.4 (#34)
5612e5f 
* Update changelog and bump to v2.0.4
* Specifically thank @dbaxa for this change.

Signed-off-by: Jesse Whitehouse <[email protected]>
Jesse
Bump to 2.0.5-dev on main (#35)
f1241ba 
Signed-off-by: Jesse Whitehouse <[email protected]>
Jesse
On Pypi, display the "Project Links" sidebar. (#36)
6bafb9d 
Signed-off-by: Jesse Whitehouse <[email protected]>
Jesse
[ES-402013] Close cursors before closing connection (#38)
afcb0f0 
* Add test: cursors are closed when connection closes

Signed-off-by: Jesse Whitehouse <[email protected]>
Jesse
Bump version to 2.0.5 and improve CHANGELOG (#40)
af945aa 
Signed-off-by: Jesse Whitehouse <[email protected]>
@moderakh
fix dco issue
441a6ae 
Signed-off-by: Moe Derakhshani <[email protected]>
@moderakh
fix dco issue
29fe6b4 
Signed-off-by: Moe Derakhshani <[email protected]>
@moderakh
Merge pull request #42 from moderakh/fix-dco-issue
06d9df8 
Signed-off-by: Moe Derakhshani <[email protected]>

my [OAuth PR](https://github.com/databricks/databricks-sql-python/runs/8005844758?check_suite_focus=true) is blocked due to dco validation (following error):
<img width="1202" alt="Screen Shot 2022-08-25 at 12 05 40 PM" src="https://user-images.githubusercontent.com/22279672/186747897-c9d57586-366f-41f9-aa66-609f2bf3911f.png">



We should try to avoid running dco for internal databricks employees:
I am trying to relax the validation based on this guideline:
https://github.com/dcoapp/app/blob/main/README.md#skipping-sign-off-for-organization-members

and here:
https://stackoverflow.com/questions/62969381/is-it-in-line-with-the-dco-that-a-github-sign-off-needs-and-publishes-full-name
@moderakh
dco tunning
cf3130e 
Signed-off-by: Moe Derakhshani <[email protected]>
@moderakh
dco tunning
4387f93 
Signed-off-by: Moe Derakhshani <[email protected]>
@moderakh
Merge pull request #43 from moderakh/dco-tunning
285e516 
Signed-off-by: Moe Derakhshani <[email protected]>

this is undo of #42 till we figure out how to fix dco
Jesse
Github workflows: run checks on pull requests from forks (#47)
ea0f076 
Signed-off-by: Jesse Whitehouse <[email protected]>
@moderakh
OAuth implementation (#15)
616a5c8 
This PR:
* Adds the foundation for OAuth against Databricks account on AWS with BYOIDP.
* It copies one internal module that Steve Weis @sweisdb wrote for Databricks CLI (oauth.py). Once ecosystem-dev team (Serge, Pieter) build a python sdk core we will move this code to their repo as a dependency. 
* the PR provides authenticators with visitor pattern format for stamping auth-token which later is intended to be moved to the repo owned by Serge @nfx and and Pieter @pietern
Jesse
Automate deploys to Pypi (#48)
e39d294 
Signed-off-by: Jesse Whitehouse <[email protected]>
Jesse
[PECO-205] Add functional examples (#52)
1ea2fe0 
Signed-off-by: Jesse Whitehouse <[email protected]>
Jesse
Bump version to 2.1.0 (#54)
3638fa2 
Bump to v2.1.0 and update changelog

Signed-off-by: Jesse Whitehouse <[email protected]>
@mohitsingla-db @moderakh
[SC-110400] Enabling compression in Python SQL Connector (#49)
1a4cf4b 
Signed-off-by: Mohit Singla <[email protected]>
Co-authored-by: Moe Derakhshani <[email protected]>
Jesse
Add tests for parameter sanitisation / escaping (#46)
8d6d47f 
* Refactor so we can unit test `inject_parameters`
* Add unit tests for inject_parameters
* Remove inaccurate comment. Per #51, spark sql does not support escaping a single quote with a second single quote.
* Closes #51 and adds unit tests plus the integration test provided in #56

Signed-off-by: Jesse Whitehouse <[email protected]>
Co-authored-by: Courtney Holcomb (@courtneyholcomb)
Co-authored-by: @mcannamela
Jesse
Bump thrift dependency to 0.16.0 (#65)
3d3c692 
Addresses https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-13949

Signed-off-by: Jesse Whitehouse <[email protected]>
Jesse
Bump version to 2.2.0 (#66)
5cbfcac 
Signed-off-by: Jesse Whitehouse <[email protected]>
Jesse
Support Python 3.11 (#60)
c6e573c 
Signed-off-by: Jesse Whitehouse <[email protected]>
Jesse
Bump version to 2.2.1 (#70)
7c53b76 
Signed-off-by: Jesse Whitehouse <[email protected]>
@jackyhu-db
Add none check on _oauth_persistence in DatabricksOAuthProvider (#71)
4f221b3 
Add none check on _oauth_persistence in DatabricksOAuthProvider to avoid app crash when _oauth_persistence is None.

Signed-off-by: Jacky Hu <[email protected]>
@jackyhu-db
Support custom oauth client id and redirect port (#75)
cfa38a1 
* Support custom oauth client id and rediret port range

PySQL is used by other tools/CLIs which have own oauth client id,
we need to expose oauth_client_id and oauth_redirect_port_range
as the connection parameters to support this customization.

Signed-off-by: Jacky Hu <[email protected]>

* Change oauth redirect port range to port

Signed-off-by: Jacky Hu <[email protected]>

* Fix type check issue

Signed-off-by: Jacky Hu <[email protected]>

Signed-off-by: Jacky Hu <[email protected]>
@jackyhu-db
Bump version to 2.2.2 (#76)
2f2a761 
Signed-off-by: Jacky Hu <[email protected]>
Signed-off-by: Jesse <[email protected]>
Jesse
Merge staging ingestion into main (#78)
def5e0e 
Follow up to #67 and #64 

* Regenerate TCLIService using latest TCLIService.thrift from DBR (#64)
* SI: Implement GET, PUT, and REMOVE (#67)
* Re-lock dependencies after merging `main`

Signed-off-by: Jesse Whitehouse <[email protected]>
Jesse
Bump version to 2.3.0 and update changelog (#80)
3cc9393 
Signed-off-by: Jesse Whitehouse <[email protected]>
@lu-wang-dl
Add pkgutil-style for the package (#84)
aa55a6e 
Since the package is under databricks namespace. pip install this package will cause issue importing other packages under the same namespace like automl and feature store. Adding pkgutil style to resolve the issue.

Signed-off-by: lu-wang-dl <[email protected]>
Jesse
Add SQLAlchemy Dialect (#57)
ce158cb 
Signed-off-by: Jesse Whitehouse <[email protected]>
@saishreeeee
logger.error to logger.debug
37a8803 
Signed-off-by: Sai Shree Pradhan <[email protected]>
@saishreeeee
saishreeeee temporarily deployed to azure-prod July 8, 2025 10:13 — with GitHub Actions Inactive
@github-actions

github-actions Bot commented Jul 8, 2025

Copy link
Copy Markdown

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jprakash-db
jprakash-db reviewed Jul 8, 2025
View reviewed changes
Comment thread src/databricks/sql/client.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/databricks/sql/telemetry/latency_logger.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/databricks/sql/telemetry/latency_logger.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/databricks/sql/telemetry/models/endpoint_models.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/databricks/sql/telemetry/models/endpoint_models.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/databricks/sql/telemetry/telemetry_client.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/databricks/sql/telemetry/telemetry_client.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread tests/unit/test_telemetry.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread tests/unit/test_telemetry.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread src/databricks/sql/telemetry/telemetry_client.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@saishreeeee
logging, test fixture
932ee0d 
Signed-off-by: Sai Shree Pradhan <[email protected]>
@saishreeeee
saishreeeee temporarily deployed to azure-prod July 8, 2025 20:17 — with GitHub Actions Inactive
@github-actions

github-actions Bot commented Jul 8, 2025

Copy link
Copy Markdown

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@saishreeeee
noop telemetry client lock
eb95bcc 
Signed-off-by: Sai Shree Pradhan <[email protected]>
@saishreeeee
saishreeeee temporarily deployed to azure-prod July 8, 2025 20:32 — with GitHub Actions Inactive
@github-actions

github-actions Bot commented Jul 8, 2025

Copy link
Copy Markdown

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@saishreeeee
JsonSerializableMixin, TelemetryRequest
85bfe06 
Signed-off-by: Sai Shree Pradhan <[email protected]>
@saishreeeee
saishreeeee temporarily deployed to azure-prod July 9, 2025 05:09 — with GitHub Actions Inactive
@github-actions

github-actions Bot commented Jul 9, 2025

Copy link
Copy Markdown

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@saishreeeee
timeout 900, TelemetryResponse, BaseTelemetryClient in utils
c74b0e5 
Signed-off-by: Sai Shree Pradhan <[email protected]>
@saishreeeee
saishreeeee temporarily deployed to azure-prod July 9, 2025 08:30 — with GitHub Actions Inactive
@github-actions

github-actions Bot commented Jul 9, 2025

Copy link
Copy Markdown

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@saishreeeee
TelemetryResponse, send_count
6afa037 
Signed-off-by: Sai Shree Pradhan <[email protected]>
@saishreeeee
saishreeeee temporarily deployed to azure-prod July 9, 2025 08:59 — with GitHub Actions Inactive
@github-actions

github-actions Bot commented Jul 9, 2025

Copy link
Copy Markdown

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@saishreeeee
saishreeeee requested a review from jprakash-db July 9, 2025 09:02
vikrantpuppala
vikrantpuppala approved these changes Jul 10, 2025
View reviewed changes
Comment thread src/databricks/sql/client.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@saishreeeee
get telemetry client
341991d 
Signed-off-by: Sai Shree Pradhan <[email protected]>
@saishreeeee
saishreeeee temporarily deployed to azure-prod July 10, 2025 04:38 — with GitHub Actions Inactive
@github-actions

github-actions Bot commented Jul 10, 2025

Copy link
Copy Markdown

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jprakash-db
jprakash-db approved these changes Jul 10, 2025
View reviewed changes

@jprakash-db jprakash-db left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for making the changes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@saishreeeee
get telemetry client
c9c8793 
Signed-off-by: Sai Shree Pradhan <[email protected]>
@saishreeeee
saishreeeee temporarily deployed to azure-prod July 10, 2025 04:46 — with GitHub Actions Inactive
@github-actions

github-actions Bot commented Jul 10, 2025

Copy link
Copy Markdown

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@saishreeeee
saishreeeee merged commit 9c34acd into main Jul 10, 2025
@saishreeeee
saishreeeee deleted the telemetry branch August 1, 2025 08:12

This branch was previously deployed

1 inactive deployment
azure-prod — c9c87933 Deployed Jul 10, 2025 by saishreeeee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vikrantpuppala vikrantpuppala vikrantpuppala approved these changes
@jprakash-db jprakash-db jprakash-db approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@saishreeeee saishreeeee

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

20 participants

@saishreeeee @vikrantpuppala @jprakash-db @dbaxa @moderakh @mohitsingla-db @jackyhu-db @lu-wang-dl @shea-parkes @yunbodeng-db @andrefurlan-db @mattdeekay @sebbegg @itsdani @bkyryliuk @WilliamGentry @dbarrundia-tiger @nithinkdb @unj1m @martinitus
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.