GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Allow allocating large object from free list while background sweeping SOH by cshung · Pull Request #2103 · dotnet/runtime

Conversation

@cshung

@cshung cshung commented Jan 23, 2020 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fixes #1848

The change postponed the clearing of the free lists of the large object heap, that allows the free list to be used while the background small object heap sweeping is in progress.

Stress tests involving large object allocation mixed with all the existing test cases survived the stress run over the weekend without crashing or deadlock.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@cshung
Allow allocating large object from free list while background sweepin…
c25b551 
…g SOH
@cshung

cshung commented Jan 23, 2020

Copy link
Copy Markdown
Contributor Author

@Maoni0 is added to the review. #Closed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Maoni0

Maoni0 commented Jan 23, 2020

Copy link
Copy Markdown
Member

these 2 lines can be gotten rid of

Refers to: src/coreclr/src/gc/gc.cpp:34466 in c25b551. [](commit_id = c25b551, deletion_comment = False)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Maoni0

Maoni0 commented Jan 23, 2020

Copy link
Copy Markdown
Member

hmm, too bad the lines didn't actually get displayed (just the line #) but if you open this in codeflow it should work
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jkotas jkotas added the area-GC-coreclr label Jan 24, 2020
@cshung
Code review feedback
bd6dfe7
@cshung cshung changed the title [WIP] Allow allocating large object from free list while background sweeping SOH Allow allocating large object from free list while background sweeping SOH Jan 24, 2020
@cshung
cshung requested a review from Maoni0 January 24, 2020 19:50
Maoni0
Maoni0 approved these changes Jan 28, 2020
View reviewed changes

@Maoni0 Maoni0 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@cshung
cshung merged commit 04f77ba into dotnet:master Jan 28, 2020
@cshung
cshung deleted the dev/andrewau/keep-loh-freelist branch January 28, 2020 02:08
VSadov added a commit to VSadov/runtime that referenced this pull request Jan 29, 2020
@VSadov
re-implemented dotnet#2103 on top of refactoring (it was hard to merge)
1dba378
VSadov added a commit that referenced this pull request Jan 29, 2020
@VSadov
Refactor handling of non-SOH generations (#1688)
1336238 
* refactoring

* ploh-->uoh

* fix Linux build
PR feedback

* some PR feedback

* more PR feedback

more PR feedback

* more PR feedback

* address comments in UpdatePreGCCounters

* removed a confusing comment

* stress fix in background sweep

* use `saved_sweep_ephemeral_seg` in background sweep.

* fixed `GCPerHeapHistory_V3` event.

* re-implemented #2103 on top of refactoring  (it was hard to merge)
@jkoritzinsky jkoritzinsky mentioned this pull request Feb 7, 2020
Fix using the nopgooptimize flag in the CoreCLR build scripts. #31931
Merged
MichalStrehovsky pushed a commit to MichalStrehovsky/corert that referenced this pull request Mar 28, 2020
@VSadov @MichalStrehovsky
Refactor handling of non-SOH generations (dotnet#1688)
ae11539 
* refactoring

* ploh-->uoh

* fix Linux build
PR feedback

* some PR feedback

* more PR feedback

more PR feedback

* more PR feedback

* address comments in UpdatePreGCCounters

* removed a confusing comment

* stress fix in background sweep

* use `saved_sweep_ephemeral_seg` in background sweep.

* fixed `GCPerHeapHistory_V3` event.

* re-implemented dotnet/runtime#2103 on top of refactoring  (it was hard to merge)
MichalStrehovsky pushed a commit to MichalStrehovsky/corert that referenced this pull request Mar 31, 2020
@VSadov @MichalStrehovsky
Refactor handling of non-SOH generations (dotnet#1688)
42903d7 
* refactoring

* ploh-->uoh

* fix Linux build
PR feedback

* some PR feedback

* more PR feedback

more PR feedback

* more PR feedback

* address comments in UpdatePreGCCounters

* removed a confusing comment

* stress fix in background sweep

* use `saved_sweep_ephemeral_seg` in background sweep.

* fixed `GCPerHeapHistory_V3` event.

* re-implemented dotnet/runtime#2103 on top of refactoring  (it was hard to merge)
jkotas pushed a commit to dotnet/corert that referenced this pull request Apr 1, 2020
@VSadov @jkotas
Refactor handling of non-SOH generations (#1688)
44ef221 
* refactoring

* ploh-->uoh

* fix Linux build
PR feedback

* some PR feedback

* more PR feedback

more PR feedback

* more PR feedback

* address comments in UpdatePreGCCounters

* removed a confusing comment

* stress fix in background sweep

* use `saved_sweep_ephemeral_seg` in background sweep.

* fixed `GCPerHeapHistory_V3` event.

* re-implemented dotnet/runtime#2103 on top of refactoring  (it was hard to merge)
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Maoni0 Maoni0 Maoni0 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

area-GC-coreclr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

LOH free list shouldn't be reset till we start sweeping it in BGC

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@cshung @Maoni0 @jkotas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.